Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component children do not inherit parent providers #459

Closed
lbialy opened this issue Apr 17, 2024 · 1 comment
Closed

Component children do not inherit parent providers #459

lbialy opened this issue Apr 17, 2024 · 1 comment
Assignees
@lbialy
Labels
area/core The SDK's core code impact/broken Something that is difficult or impossible for some people to use kind/bug Some behavior is incorrect or out of spec P1 Bugs severe enough to be the next item assigned to an engineer size/S Estimated effort to complete (1-2 days).
Milestone
0.3.1

Comments

@lbialy
Copy link
Collaborator

lbialy commented Apr 17, 2024

One of the improvements that Besom has over other Pulumi SDKs is that components are much less error prone because they require less manual steps - user doesn't have to manually call registerOutputs, user doesn't have to pass component instance as parent reference to all resources. The latter is only necessary for our internals to look up parents providers (a Map[String, ProviderResource] in case of components) and propagate them to children. Our implementation correctly propagated parent URN (this is a separate mechanic) that created logical hierarchies of resources visible in preview as subtrees but due to a mistake in implementation inheritance of providers was left out.
@lbialy lbialy added kind/bug Some behavior is incorrect or out of spec impact/broken Something that is difficult or impossible for some people to use area/core The SDK's core code P1 Bugs severe enough to be the next item assigned to an engineer size/S Estimated effort to complete (1-2 days). labels Apr 17, 2024
@lbialy lbialy added this to the 0.3.1 milestone Apr 17, 2024
@lbialy lbialy self-assigned this Apr 17, 2024
@lbialy
Copy link
Collaborator Author

lbialy commented Apr 17, 2024

PR #460

@lbialy lbialy closed this as completed Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbialy lbialy

Labels
area/core The SDK's core code impact/broken Something that is difficult or impossible for some people to use kind/bug Some behavior is incorrect or out of spec P1 Bugs severe enough to be the next item assigned to an engineer size/S Estimated effort to complete (1-2 days).
Projects
None yet
Milestone
0.3.1
Development

No branches or pull requests
1 participant
@lbialy