Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lifts to Output[Option[List[A]]] etc. #445

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Add lifts to Output[Option[List[A]]] etc. #445

merged 1 commit into from
Apr 10, 2024

Conversation

pawelprazak
Copy link
Contributor

Fixes #424

@pawelprazak pawelprazak added the area/api User visible API label Apr 9, 2024
@pawelprazak pawelprazak added this to the 0.3.0 milestone Apr 9, 2024
@pawelprazak pawelprazak requested a review from lbialy April 9, 2024 06:37
@pawelprazak
Copy link
Contributor Author

Added the requested getOrFail, and scaladocs for public methods.

@pawelprazak pawelprazak force-pushed the pprazak/output-lifts branch 2 times, most recently from c4bcc28 to 4d0a2f6 Compare April 9, 2024 10:39
lbialy
lbialy requested changes Apr 9, 2024
View reviewed changes
core/src/main/scala/besom/internal/Output.scala Outdated Show resolved Hide resolved
core/src/main/scala/besom/internal/Output.scala Show resolved Hide resolved
core/src/main/scala/besom/internal/Output.scala Outdated Show resolved Hide resolved
core/src/main/scala/besom/internal/Output.scala Outdated Show resolved Hide resolved
core/src/main/scala/besom/internal/Output.scala Outdated Show resolved Hide resolved
core/src/main/scala/besom/internal/Output.scala Outdated Show resolved Hide resolved
core/src/main/scala/besom/internal/Output.scala Outdated Show resolved Hide resolved
core/src/main/scala/besom/internal/Output.scala Outdated Show resolved Hide resolved
core/src/main/scala/besom/internal/Output.scala Outdated Show resolved Hide resolved
@pawelprazak pawelprazak force-pushed the pprazak/output-lifts branch 3 times, most recently from 42fd3fe to 6e9ff88 Compare April 9, 2024 13:08
@pawelprazak
Copy link
Contributor Author

Addressed the comments. Extended signatures of mapInner / flatMap inner for lists to match option. Added unit tests.

@pawelprazak pawelprazak requested a review from lbialy April 9, 2024 13:09
@pawelprazak
Copy link
Contributor Author

I've rebased onto main.

@pawelprazak pawelprazak merged commit 7ab46a7 into main Apr 10, 2024
2 checks passed
@pawelprazak pawelprazak deleted the pprazak/output-lifts branch April 10, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbialy lbialy lbialy approved these changes

Assignees
No one assigned
Labels
area/api User visible API
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

Consider adding lifted methods for Output[List[A]] and Output[Option[List[A]]], and Output[Option[A]]
2 participants
@pawelprazak @lbialy