Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix several bugs in array type handling in dotnet module #2064

Merged
merged 1 commit into from
May 2, 2024

Commits on Apr 30, 2024

  1. fix several bugs in array type handling in dotnet module

    Several bugs were present in the parsing and generation of a string to
    represent an array type, notably when the "lo_bound" value is set.
    
    - The "read_blob_signed" was buggy for values outside the
      [-2**6, 2**6-1], the sign edition did not use the right bitmask,
      and the type used was unsigned.
    
    - The display when lo_bound != 0 was buggy:
    
      - size=5, lobound=0 => should be `5`, this was ok
      - size=5, lobound=1 => should be `1...5`, this was buggy and displayed
        `1...6`. The "range format" is inclusive.
    
    - 0 should still be displayed if size is 0. Only when size is unset
      should it be left out. So an array declared as `[5,0,3]` should be
      displayed the same way, and not as `[5,,3]`.
    vthib committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    953df53 View commit details
    Browse the repository at this point in the history