Feature/events #36
Merged
Feature/events #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kowal
reviewed
Aug 22, 2019
app/helpers/select_helper.rb
Outdated
| return unless array.respond_to?(:map) | ||
|
|
||
| array.map { |s| [s.humanize, s] } | ||
| array.map { |s| [s.send(transform_func), s] } |
There was a problem hiding this comment.
can we add a respond_to? check here?
app/models/litigation.rb
Outdated
| has_and_belongs_to_many :legislations | ||
|
|
||
| accepts_nested_attributes_for :documents, allow_destroy: true | ||
| accepts_nested_attributes_for :litigation_sides, allow_destroy: true | ||
| accepts_nested_attributes_for :documents, allow_destroy: true, reject_if: :all_blank |
There was a problem hiding this comment.
maybe:
with_options allow_destroy: true, reject_if: :all_blank do
accepts_nested_attributes_for :documents
accepts_nested_attributes_for :litigation_sides
accepts_nested_attributes_for :events
end
app/models/event.rb
Outdated
| validates :event_type, presence: true, inclusion: {in: :valid_types} | ||
|
|
||
| def valid_types | ||
| return Litigation::EVENT_TYPES if eventable.is_a?(Litigation) |
There was a problem hiding this comment.
here I would just put eventable.event_types and leave validation for "eventable" model.
There was a problem hiding this comment.
Validation must be here I guess? but I could add event_types to eventable model sure that's a good idea 👍 but that method must be implemented by all eventables.
|
There is a difference in order of tabs between show and edit pages: Show:
Edit:
For me the order could be: |
|
All right, I will change that. Documents won't have tab (at least for now), that's only list of links |
|
Ready again @kowal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.