Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added rake import task for legislation data #5

Merged
merged 1 commit into from
Jul 19, 2019
Merged

added rake import task for legislation data #5

merged 1 commit into from
Jul 19, 2019

Conversation

kowal
Copy link
Contributor

@kowal kowal commented Jul 18, 2019 •
edited
Loading

Imported Legislation items

Zrzut ekranu 2019-07-18 o 22 56 35

Problems:

  • not sure how to handle slugs for this, right now title is used, but it could be really long text
  • one row was invalid (due to NDL location code):

Zrzut ekranu 2019-07-18 o 22 57 15

@kowal kowal force-pushed the feature/legislations-importer branch from 8cf5b3e to e6a4835 Compare July 18, 2019 20:51
@kowal kowal requested a review from tsubik July 18, 2019 20:52
@kowal kowal marked this pull request as ready for review July 18, 2019 20:55
tsubik
tsubik approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@tsubik tsubik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 We don't have to worry about a few import errors now.

@tsubik tsubik merged commit 3262fe5 into develop Jul 19, 2019
@tsubik tsubik deleted the feature/legislations-importer branch July 19, 2019 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsubik tsubik tsubik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kowal @tsubik