Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add last reported year to cp assessments #78

Merged
merged 2 commits into from
Oct 7, 2019
Merged

add last reported year to cp assessments #78

merged 2 commits into from
Oct 7, 2019

Conversation

tsubik
Copy link
Contributor

@tsubik tsubik commented Oct 7, 2019

Small PR to add last reported year to CP::Assessment model. This year is a boundary between reported and targeted emission data.

kowal
kowal approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@kowal kowal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. can you also annotate models?

@tsubik
Copy link
Contributor Author

tsubik commented Oct 7, 2019

Done. Thanks for reminding me.

@tsubik tsubik merged commit 05fe834 into develop Oct 7, 2019
@kowal kowal deleted the feature/add-last-reported-year branch October 14, 2019 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kowal kowal kowal approved these changes

@agwozdowski agwozdowski Awaiting requested review from agwozdowski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsubik @kowal