Feature/ 'assessments levels over the years' chart

[kowal]

Summary

Add Assessment Levels/years chart for (TPI) Management Quality for Company

Details

• New endpoint returns data in format: [[2016,2],[2017,2],[2018,4]]
• ::Api::Charts::Company.new(@company).nr_of_assessments_data always provides data for each year starting from latest year to most recent, filling missing years levels with last reported level.

Mockups

Example

More than 1 assessment (http://localhost:3000/tpi/companies/314)

When only 1 assessment (http://localhost:3000/tpi/companies/460)

Questions

• should the chart X axis end on last reported year or current year? Yes
• what to do with companies which has only single MQ assessment in current year? We can't draw line in that case, so chart doesn't make sense. Draw a dot

[simaob]

Thanks for this Kowal! =) I think that we should show current year as the latest year on the xx axis, this way it gives more context and can make it easier for people to see if companies submitted something this year.

One there's only one MQ Assessment we can just show a single dot, no? I think it's fair.

[kowal]

.. I think that we should show current year as the latest year on the xx axis, this way it gives more context and can make it easier for people to see if companies submitted something this year.

Yep, make sense, so I need to fix that in this PR

One there's only one MQ Assessment we can just show a single dot, no? I think it's fair.

OK, that's how it works now.

[kowal]

.. I think that we should show current year as the latest year on the xx axis, this way it gives more context and can make it easier for people to see if companies submitted something this year.

Yep, make sense, so I need to fix that in this PR

.. although it might make sense to somehow distinguish it visually. This case means that we don't have data for those last year(s), but we're assuming MQ a. level didn't change - but it could - a company could have done better/worst job but we just don't know it.

[kowal]

@simaob I fixed the chart to always end on the current year, also I simplified the logic. I still need to add tests for this.

[tsubik]

I wonder if we should take a year from an assessment date or publication date. Also what happens when there are two assessments/publications in the given year. Take a look at company Bukit Asam, the level is 1 because in the same year there were two assessments. But the second assessment was published the next year.

Maybe we should take publication date for this chart.

[kowal]

I wonder if we should take a year from an assessment date or publication date. Also what happens when there are two assessments/publications in the given year. Take a look at company Bukit Asam, the level is 1 because in the same year there were two assessments. But the second assessment was published the next year.

Maybe we should take publication date for this chart.

Great catch! will fix that in the next days. I think switching to publication date make sense. @simaob ?

[tsubik]

Or we should just go more granular there. Not years, but month-year for axis-x

[tsubik]

There could be 2 publications within one year.

[faustoperez]

Hi folks! The assessment dates should have a month and a year, so more granularity is needed.

On the x-axis, we would show the year only, but we could have an additional data point if needed.

It's covered on the design mockups (2 data points for March 2018)

Hope this helps :)

[tsubik]

I only show the points for real assessments. I removed that assumption that level stays the same when there was no assessment in the given year.

So the chart looks like this now. The number of data points is the number of assessments.

Do you think that is a good approach @simaob ?

[tsubik]

Also, I'm using slugs to access companies and sectors on the public site. http://localhost:3000/tpi/companies/acerinox, http://localhost:3000/tpi/companies/bukit-asam

[tsubik]

👍