Feature/litigation sides edit #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pivotal story here |
kowal
reviewed
Jul 25, 2019
| <%= form.input :party_type, as: :select, collection: array_to_select_collection(LitigationSide::PARTY_TYPES) %> | ||
|
|
||
| <li class="input"> | ||
| <%= button_tag "Remove", type: 'button', class: 'button button--raised button--red', data: { action: "click->nested-list#removeRecord" } %> |
There was a problem hiding this comment.
do we need double quotes around "click->nested-list#removeRecord" (and in other actions)?
| @@ -31,6 +31,7 @@ group :development, :test do | |||
| gem 'byebug', platforms: [:mri, :mingw, :x64_mingw] | |||
| gem 'capybara' | |||
| gem 'factory_bot_rails' | |||
| gem 'rails-controller-testing' | |||
There was a problem hiding this comment.
is this used anywhere? I can't see any assigns or assert_template.
There was a problem hiding this comment.
Right, I've been debugging failed test and I needed assigns. Maybe it can stay for debugging.
| } | ||
|
|
||
| _setDefaults() { | ||
| const selectedOption = this.connectedWithSelect.selectedOptions && |
There was a problem hiding this comment.
I'd extract this.getSelectedOption() for this.
app/models/litigation_side.rb
Outdated
| end | ||
|
|
||
| def self.available_connections | ||
| (Company.all + Location.all).map { |c| [c.name, "#{c.class}-#{c.id}"] } |
There was a problem hiding this comment.
(Company.all.select(:id, :name) + Location.all.select(:id, :name)).map { .. }
app/services/import_litigations.rb
Outdated
| @@ -16,6 +16,10 @@ def import | |||
| import_each_with_logging(csv, FILEPATH) do |row| | |||
| l = Litigation.find_or_initialize_by(title: row[:title]) | |||
| l.update!(litigation_attributes(row)) | |||
| get_litigation_sides(row).each do |side| | |||
| side.litigation_id = l.id | |||
There was a problem hiding this comment.
side.update(litigation_id: l.id) ?
|
Thanks for the review @kowal PR Ready again. Please mind that I also changed the menu structure a little bit.
|
kowal
approved these changes
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Edit for litigation sides and also the ability to connect to system entities like Location or Company through polymorphic association.
Reimport litigations