fix(home): applying more style fixes and extra assets #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rapzo
commented
Nov 7, 2019
rapzo
commented
- reworked stylesheets' directories
|
Bring back |
- reworked stylesheets' directories
aabdaab
reviewed
Nov 7, 2019
| } | ||
|
|
||
| .navbar-dropdown { | ||
| @if $desktop { |
There was a problem hiding this comment.
Yap. But $desktop is defined in bulma though. We only configure the breakpoints variables in application.scss (for now, at least).
| // $size-3: 2.5rem; | ||
| // $size-4: 2rem; | ||
| // $size-5: 1.5rem; | ||
| // $size-6: 1rem; |
There was a problem hiding this comment.
are we gonna need them later?
There was a problem hiding this comment.
Bulma defines and uses the $size-1 to $size-7. The commented values are the default values kept only for reference, since they match our specs.
|
Thanks for rearranging the styles 👏 I'm gonna merge this but we need to reiterate on the home page (we should add PT task for that if there is none?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.