Fix resolution for simulation and inflow calc #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erny-powel
force-pushed
the
erny/hydsim-resolution-timedelta
branch
from
94beeaa to
105c9e8
Compare
When implementing run_simulation and run_inflow_calculation I used our predefined protobuf time series resolutions for simulation and inflow calculation resolution. This is not correct and those might run on resolutions we don't allow for time series. Update proto to use https://github.com/protocolbuffers/protobuf/blob/main/src/google/protobuf/duration.proto, which is used by the Mesh server starting with v2.14.0. See Volue/energy-mesh#5305 (internal). See Volue/energy-mesh#5317 (internal).
erny-powel
force-pushed
the
erny/hydsim-resolution-timedelta
branch
from
105c9e8 to
17f78c2
Compare
simia
approved these changes
May 6, 2024
| @@ -15,7 +15,9 @@ Compatible with | |||
| New features | |||
| ~~~~~~~~~~~~~~~~~~ | |||
|
|
|||
| - TBA | |||
| - It's now possible to specify the resolution of a hydro simulation or inflow | |||
| calculation using the optinal `resolution` argument to `run_simulation` and | |||
There was a problem hiding this comment.
optinal -> optional ?
There was a problem hiding this comment.
Yes, good catch 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implementing run_simulation and run_inflow_calculation I used our predefined protobuf time series resolutions for simulation and inflow calculation resolution. This is not correct and those might run on resolutions we don't allow for time series.
Update proto to use
https://github.com/protocolbuffers/protobuf/blob/main/src/google/protobuf/duration.proto, which is used by the Mesh server starting with v2.14.0.
See https://github.com/Volue/energy-mesh/issues/5305 (internal).
See https://github.com/Volue/energy-mesh/pull/5317 (internal).