diff --git a/Vonage.Test/ConversionTest.cs b/Vonage.Test/ConversionTest.cs index ff52db1e3..ca86de1b2 100644 --- a/Vonage.Test/ConversionTest.cs +++ b/Vonage.Test/ConversionTest.cs @@ -8,33 +8,6 @@ namespace Vonage.Test; [Trait("Category", "Legacy")] public class ConversionTest : TestBase { - [Theory] - [InlineData(false)] - [InlineData(true)] - public void SmsConversion(bool passCreds) - { - var expectedUri = $"{this.ApiUrl}/conversions/sms"; - var expectedContent = - "message-id=00A0B0C0&delivered=true×tamp=2020-01-01+12%3A00%3A00&api_key=testkey&api_secret=testSecret&"; - var expectedResponse = ""; - this.Setup(expectedUri, expectedResponse, expectedContent); - var request = new ConversionRequest - {Delivered = true, MessageId = "00A0B0C0", TimeStamp = "2020-01-01 12:00:00"}; - var credentials = Credentials.FromApiKeyAndSecret(this.ApiKey, this.ApiSecret); - var client = this.BuildVonageClient(credentials); - bool response; - if (passCreds) - { - response = client.ConversionClient.SmsConversion(request, credentials); - } - else - { - response = client.ConversionClient.SmsConversion(request); - } - - Assert.True(response); - } - [Theory] [InlineData(false)] [InlineData(true)] @@ -62,33 +35,6 @@ public async Task SmsConversionAsync(bool passCreds) Assert.True(response); } - [Theory] - [InlineData(false)] - [InlineData(true)] - public void VoiceConversion(bool passCreds) - { - var expectedUri = $"{this.ApiUrl}/conversions/voice"; - var expectedContent = - "message-id=00A0B0C0&delivered=true×tamp=2020-01-01+12%3A00%3A00&api_key=testkey&api_secret=testSecret&"; - var expectedResponse = ""; - this.Setup(expectedUri, expectedResponse, expectedContent); - var request = new ConversionRequest - {Delivered = true, MessageId = "00A0B0C0", TimeStamp = "2020-01-01 12:00:00"}; - var creds = Credentials.FromApiKeyAndSecret(this.ApiKey, this.ApiSecret); - var client = this.BuildVonageClient(creds); - bool response; - if (passCreds) - { - response = client.ConversionClient.VoiceConversion(request, creds); - } - else - { - response = client.ConversionClient.VoiceConversion(request); - } - - Assert.True(response); - } - [Theory] [InlineData(false)] [InlineData(true)] diff --git a/Vonage/Conversions/ConversionClient.cs b/Vonage/Conversions/ConversionClient.cs index b5b06d049..cb5b75558 100644 --- a/Vonage/Conversions/ConversionClient.cs +++ b/Vonage/Conversions/ConversionClient.cs @@ -1,5 +1,4 @@ -using System; -using System.Threading.Tasks; +using System.Threading.Tasks; using Vonage.Common; using Vonage.Request; @@ -25,19 +24,6 @@ internal ConversionClient(Credentials credentials, Configuration configuration, public Credentials Credentials { get; set; } - /// - [Obsolete("Favor asynchronous version instead.")] - public bool SmsConversion(ConversionRequest request, Credentials creds = null) - { - ApiRequest.Build(this.GetCredentials(creds), this.configuration, this.timeProvider) - .DoPostRequestUrlContentFromObject - ( - ApiRequest.GetBaseUri(ApiRequest.UriType.Api, this.configuration, "/conversions/sms"), - request - ); - return true; - } - /// public async Task SmsConversionAsync(ConversionRequest request, Credentials creds = null) { @@ -50,19 +36,6 @@ await ApiRequest.Build(this.GetCredentials(creds), this.configuration, this.time return true; } - /// - [Obsolete("Favor asynchronous version instead.")] - public bool VoiceConversion(ConversionRequest request, Credentials creds = null) - { - ApiRequest.Build(this.GetCredentials(creds), this.configuration, this.timeProvider) - .DoPostRequestUrlContentFromObject - ( - ApiRequest.GetBaseUri(ApiRequest.UriType.Api, this.configuration, "/conversions/voice"), - request - ); - return true; - } - /// public async Task VoiceConversionAsync(ConversionRequest request, Credentials creds = null) { diff --git a/Vonage/Conversions/IConversionClient.cs b/Vonage/Conversions/IConversionClient.cs index 1f9980042..4b8709949 100644 --- a/Vonage/Conversions/IConversionClient.cs +++ b/Vonage/Conversions/IConversionClient.cs @@ -13,23 +13,7 @@ public interface IConversionClient /// /// Task SmsConversionAsync(ConversionRequest request, Credentials creds = null); - /// - /// Send a Conversion API request with information about the Call or Text-To-Speech identified by message-id. - /// Vonage uses your conversion data and internal information about message-id to help improve our routing of messages in the future. - /// - /// - /// - /// - Task VoiceConversionAsync(ConversionRequest request, Credentials creds = null); - /// - /// Send a Conversion API request with information about the SMS message identified by message-id. - /// Vonage uses your conversion data and internal information about message-id to help improve our routing of messages in the future. - /// - /// - /// - /// - bool SmsConversion(ConversionRequest request, Credentials creds = null); /// /// Send a Conversion API request with information about the Call or Text-To-Speech identified by message-id. /// Vonage uses your conversion data and internal information about message-id to help improve our routing of messages in the future. @@ -37,5 +21,5 @@ public interface IConversionClient /// /// /// - bool VoiceConversion(ConversionRequest request, Credentials creds = null); + Task VoiceConversionAsync(ConversionRequest request, Credentials creds = null); } \ No newline at end of file