diff --git a/Vonage.Test/NccoTests.cs b/Vonage.Test/NccoTests.cs index efbf0741..c17ec2d9 100644 --- a/Vonage.Test/NccoTests.cs +++ b/Vonage.Test/NccoTests.cs @@ -1,4 +1,5 @@ using System.Collections.Generic; +using FluentAssertions; using Newtonsoft.Json; using Vonage.Serialization; using Vonage.Voice; @@ -22,7 +23,7 @@ public void TestAppEndpoint() Assert.Equal(expectedJson, JsonConvert.SerializeObject(endpoint, VonageSerialization.SerializerSettings)); } - + [Fact] public void TestConnect() { @@ -55,7 +56,7 @@ public void TestConnect() var actualJson = ncco.ToString(); Assert.Equal(expectedJson, actualJson); } - + [Fact] public void TestConnectWithAdvancedMachineDetection() { @@ -88,7 +89,7 @@ public void TestConnectWithAdvancedMachineDetection() }; Assert.Equal(this.GetRequestJson(), new Ncco(connectAction).ToString()); } - + [Fact] public void TestConversation() { @@ -107,7 +108,7 @@ public void TestConversation() var actualJson = ncco.ToString(); Assert.Equal(expectedJson, actualJson); } - + [Fact] public void TestConversationAllTrue() { @@ -126,7 +127,11 @@ public void TestConversationAllTrue() var actualJson = ncco.ToString(); Assert.Equal(expectedJson, actualJson); } - + + [Fact] + public void ConversationAction_StartOnEnter_ShouldBeTrue_GivenDefault() => + new ConversationAction().StartOnEnter.Should().BeTrue(); + [Fact] public void TestNotify() { @@ -144,7 +149,7 @@ public void TestNotify() var actualJson = ncco.ToString(); Assert.Equal(expectedJson, actualJson); } - + [Theory] [InlineData(RecordAction.AudioFormat.Mp3)] [InlineData(RecordAction.AudioFormat.Wav)] @@ -170,7 +175,7 @@ public void TestRecord(RecordAction.AudioFormat audioFormat) var actualJson = ncco.ToString(); Assert.Equal(expectedJson, actualJson); } - + [Fact] public void TestRecordMinimalist() { @@ -180,7 +185,7 @@ public void TestRecordMinimalist() var actualJson = ncco.ToString(); Assert.Equal(expectedJson, actualJson); } - + [Fact] public void TestSipEndpoint() { @@ -193,7 +198,7 @@ public void TestSipEndpoint() Assert.Equal(expectedJson, JsonConvert.SerializeObject(endpoint, VonageSerialization.SerializerSettings)); } - + [Fact] public void TestStream() { @@ -209,7 +214,7 @@ public void TestStream() var actualJson = ncco.ToString(); Assert.Equal(expectedJson, actualJson); } - + [Fact] public void TestTalk() { @@ -227,7 +232,7 @@ public void TestTalk() var actualJson = ncco.ToString(); Assert.Equal(expectedJson, actualJson); } - + [Fact] public void TestTalkBareBones() { @@ -240,7 +245,7 @@ public void TestTalkBareBones() var actualJson = ncco.ToString(); Assert.Equal(expectedJson, actualJson); } - + [Fact] public void TestVbcEndpoint() { @@ -252,7 +257,7 @@ public void TestVbcEndpoint() Assert.Equal(expectedJson, JsonConvert.SerializeObject(endpoint, VonageSerialization.SerializerSettings)); } - + [Fact] public void TestWebsocketEndpoint() { @@ -266,7 +271,7 @@ public void TestWebsocketEndpoint() Assert.Equal(expectedJson, JsonConvert.SerializeObject(endpoint, VonageSerialization.SerializerSettings)); } - + private class TestClass { public string Bar { get; set; } diff --git a/Vonage/Voice/Nccos/ConversationAction.cs b/Vonage/Voice/Nccos/ConversationAction.cs index eb9373e7..34c92e22 100644 --- a/Vonage/Voice/Nccos/ConversationAction.cs +++ b/Vonage/Voice/Nccos/ConversationAction.cs @@ -71,5 +71,5 @@ public class ConversationAction : NccoAction /// joins conversation name. Set to false for attendees in a moderated conversation. /// [JsonProperty("startOnEnter", DefaultValueHandling = DefaultValueHandling.Include, Order = 3)] - public bool StartOnEnter { get; set; } + public bool StartOnEnter { get; set; } = true; } \ No newline at end of file