From fd02cd530c59ffa32eb111e545c7d6da44d83a7a Mon Sep 17 00:00:00 2001
From: tr00d <guillaume.faas@live.fr>
Date: Mon, 15 Apr 2024 08:18:54 +0200
Subject: [PATCH] refactor: [breaking] remove EventUrl and EventMethod from
 ConversationAction, with a disclaimer in the Readme

---
 README.md                                |  6 ++++++
 Vonage/Voice/Nccos/ConversationAction.cs | 26 +++++++-----------------
 2 files changed, 13 insertions(+), 19 deletions(-)

diff --git a/README.md b/README.md
index 45b1de488..7b0a7cda0 100644
--- a/README.md
+++ b/README.md
@@ -46,6 +46,12 @@ first.
 
 #### Upgrading from v6.x.x to v7.0.0
 
+Disclaimer: Due to a forgotten breaking changes,
+versions [v7.0.0](https://github.com/Vonage/vonage-dotnet-sdk/releases/tag/v7.0.0)
+and [v7.1.0](https://github.com/Vonage/vonage-dotnet-sdk/releases/tag/v7.1.0) have been unlisted to
+make [v7.2.0](https://github.com/Vonage/vonage-dotnet-sdk/releases/tag/v7.2.0) the logical upgrade when migrating
+towards the new major version.
+
 Please see the dedicated [migration guide](MIGRATION_v7.0.0.md).
 
 #### Upgrading from v5.x.x to v6.0.0
diff --git a/Vonage/Voice/Nccos/ConversationAction.cs b/Vonage/Voice/Nccos/ConversationAction.cs
index bf1a6d142..eb9373e7c 100644
--- a/Vonage/Voice/Nccos/ConversationAction.cs
+++ b/Vonage/Voice/Nccos/ConversationAction.cs
@@ -12,7 +12,7 @@ public class ConversationAction : NccoAction
     /// </summary>
     [JsonProperty("action", Order = 0)]
     public override ActionType Action => ActionType.Conversation;
-
+    
     /// <summary>
     ///     A list of leg UUIDs that this participant can hear.
     ///     If not provided, the participant can hear everyone.
@@ -20,7 +20,7 @@ public class ConversationAction : NccoAction
     /// </summary>
     [JsonProperty("canHear", Order = 7)]
     public string[] CanHear { get; set; }
-
+    
     /// <summary>
     ///     A list of leg UUIDs that this participant can be heard by.
     ///     If not provided, the participant can be heard by everyone.
@@ -28,7 +28,7 @@ public class ConversationAction : NccoAction
     /// </summary>
     [JsonProperty("canSpeak", Order = 6)]
     public string[] CanSpeak { get; set; }
-
+    
     /// <summary>
     ///     Specifies whether a moderated conversation ends when the moderator hangs up.
     ///     This is set to false by default, which means that the conversation only ends
@@ -38,19 +38,7 @@ public class ConversationAction : NccoAction
     /// </summary>
     [JsonProperty("endOnExit", Order = 4)]
     public bool EndOnExit { get; set; }
-
-    /// <summary>
-    ///     Method to use on the webhooks for the conversation
-    /// </summary>
-    [JsonProperty("eventMethod")]
-    public string EventMethod { get; set; }
-
-    /// <summary>
-    ///     Url to receive webhooks at for the conversation
-    /// </summary>
-    [JsonProperty("eventUrl")]
-    public string[] EventUrl { get; set; }
-
+    
     /// <summary>
     ///     A URL to the mp3 file to stream to participants until the conversation starts.
     ///     By default the conversation starts when the first person calls the virtual number
@@ -59,13 +47,13 @@ public class ConversationAction : NccoAction
     /// </summary>
     [JsonProperty("musicOnHoldUrl", Order = 2)]
     public string[] MusicOnHoldUrl { get; set; }
-
+    
     /// <summary>
     ///     The name of the Conversation room. Names are namespaced to the application level.
     /// </summary>
     [JsonProperty("name", Order = 1)]
     public string Name { get; set; }
-
+    
     /// <summary>
     ///     Set to true to record this conversation. For standard conversations,
     ///     recordings start when one or more attendees connects to the conversation.
@@ -77,7 +65,7 @@ public class ConversationAction : NccoAction
     /// </summary>
     [JsonProperty("record", Order = 5)]
     public bool Record { get; set; }
-
+    
     /// <summary>
     ///     The default value of true ensures that the conversation starts when this caller
     ///     joins conversation name. Set to false for attendees in a moderated conversation.