From 1b4e30ff53efb12275be05a2c6c47b285607fd50 Mon Sep 17 00:00:00 2001 From: Sina Madani Date: Mon, 1 Jul 2024 12:41:20 +0100 Subject: [PATCH] refactor: Simplify transferCall NCCO --- src/main/kotlin/com/vonage/client/kt/Voice.kt | 6 ++++-- src/test/kotlin/com/vonage/client/kt/VoiceTest.kt | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/main/kotlin/com/vonage/client/kt/Voice.kt b/src/main/kotlin/com/vonage/client/kt/Voice.kt index 62af4fa..38367be 100644 --- a/src/main/kotlin/com/vonage/client/kt/Voice.kt +++ b/src/main/kotlin/com/vonage/client/kt/Voice.kt @@ -1,6 +1,7 @@ package com.vonage.client.kt import com.vonage.client.voice.* +import com.vonage.client.voice.ncco.Action import com.vonage.client.voice.ncco.Ncco import java.net.URI import java.time.Instant @@ -26,7 +27,7 @@ class Voice(private val voiceClient: VoiceClient) { fun unearmuff() = voiceClient.unearmuffCall(callId) - fun transfer(ncco: Ncco) = voiceClient.transferCall(callId, ncco) + fun transfer(vararg actions: Action) = voiceClient.transferCall(callId, Ncco(actions.asList())) fun transfer(nccoUrl: String) = voiceClient.transferCall(callId, nccoUrl) @@ -60,4 +61,5 @@ fun CallsFilter.Builder.dateEnd(dateEnd: String): CallsFilter.Builder = dateEnd(Date.from(Instant.parse(dateEnd))) fun Call.Builder.advancedMachineDetection(amd: AdvancedMachineDetection.Builder.() -> Unit): Call.Builder = - advancedMachineDetection(AdvancedMachineDetection.builder().apply(amd).build()); \ No newline at end of file + advancedMachineDetection(AdvancedMachineDetection.builder().apply(amd).build()) + diff --git a/src/test/kotlin/com/vonage/client/kt/VoiceTest.kt b/src/test/kotlin/com/vonage/client/kt/VoiceTest.kt index 543a694..09f690a 100644 --- a/src/test/kotlin/com/vonage/client/kt/VoiceTest.kt +++ b/src/test/kotlin/com/vonage/client/kt/VoiceTest.kt @@ -212,7 +212,7 @@ class VoiceTest : AbstractTest() { @Test fun `transfer call with ncco`() { testModifyCall(nccoAction = mapOf("action" to "talk", "text" to text), invocation = { - callObj.transfer(Ncco(TalkAction.builder(text).build())) + callObj.transfer(TalkAction.builder(text).build()) }) }