Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voice Types #364

Closed
kellyjandrews opened this issue Oct 1, 2020 · 5 comments
Closed

Voice Types #364

kellyjandrews opened this issue Oct 1, 2020 · 5 comments
Assignees

Comments

@kellyjandrews
Copy link
Contributor

Create typings for Voice API

@peppermint-juli
Copy link

Hello! I would like to work on this issue! What is the expected result? I saw the similar issue #363 but I still don't know what should be done, add a an interface in index.d.ts file? what exactly are the types?

@kellyjandrews
Copy link
Contributor Author

Hey @PeppermintNDaisies - thanks for the offer. Take a look at #372 for a good example of what we are after. The types are in the API reference - https://developer.nexmo.com/api/voice

@peppermint-juli
Copy link

Perfect, thanks! I'll start working on this

@peppermint-juli
Copy link

Hello @kellyjandrews! I submitted a PR for this issue #379, I hope it helps, I tried my best to abstract the Voice API types and follow the code style of the project in order to get it right. If there's something wrong or that needs to be changed (or something I didn't get right) let me know and I'll do my best to fix it.

@kellyjandrews
Copy link
Contributor Author

@PeppermintNDaisies Thanks for the submission - I'll be reviewing this soon.

@kellyjandrews kellyjandrews self-assigned this Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants