Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the import from node-specific to just request http/https #722

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

dragonmantank
Copy link
Contributor

Description

Request any http or https module instead of just the core node version

Motivation and Context

This should help work better with non-standard environments.

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dragonmantank dragonmantank merged commit 34ab564 into 3.x Nov 10, 2022
@dragonmantank dragonmantank deleted the fix-change-http-call branch November 10, 2022 19:30
@dragonmantank dragonmantank restored the fix-change-http-call branch November 10, 2022 19:30
@dragonmantank dragonmantank deleted the fix-change-http-call branch November 10, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants