Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLOS2021] Other improvements #30

Open
4 tasks
JuiP opened this issue Jun 16, 2021 · 4 comments
Open
4 tasks

[RLOS2021] Other improvements #30

JuiP opened this issue Jun 16, 2021 · 4 comments

Comments

@JuiP
Copy link
Contributor

JuiP commented Jun 16, 2021

  • For intervals store min_bound and max_bound in tuple instead of List
  • For Interval get() method set alpha default value
  • Change inconsistent variable names { (w and p_over_p), (num and den in get method) }
  • Imports in the beginning of the file: change here
@cheng-tan
Copy link
Collaborator

cheng-tan commented Jun 16, 2021 •
edited
Loading

  • naming: count vs weight in add_example api

@JuiP
Copy link
Contributor Author

JuiP commented Jun 18, 2021 •
edited
Loading

  • what to do if r is out of [rmin, rmax]?
  • Change Estimator to base.Estimator
  • Rename contextual_bandits to Bandits (folder name)

@JuiP
Copy link
Contributor Author

JuiP commented Jul 16, 2021

  • Seems logically correct to change or to and here.

@JuiP
Copy link
Contributor Author

JuiP commented Jul 19, 2021

  • Add code in basicusage.py for ccb estimator.

@JuiP JuiP mentioned this issue Aug 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cheng-tan @JuiP