diff --git a/vowpalwabbit/allreduce.h b/vowpalwabbit/allreduce.h index 4c67963f89e..257dcc33e7e 100644 --- a/vowpalwabbit/allreduce.h +++ b/vowpalwabbit/allreduce.h @@ -79,7 +79,7 @@ class AllReduce AllReduce(size_t ptotal, const size_t pnode) : total(ptotal), node(pnode) - { assert(node >= 0 && node < total); + { assert(node < total); } virtual ~AllReduce() diff --git a/vowpalwabbit/noop.cc b/vowpalwabbit/noop.cc index c4c553db939..5503119a2e7 100644 --- a/vowpalwabbit/noop.cc +++ b/vowpalwabbit/noop.cc @@ -11,7 +11,7 @@ using namespace VW::config; void learn(char&, LEARNER::base_learner&, example&) {} -LEARNER::base_learner* noop_setup(options_i& options, vw& all) +LEARNER::base_learner* noop_setup(options_i& options, vw&) { bool noop = false; option_group_definition new_options("Noop Learner"); diff --git a/vowpalwabbit/parse_args.cc b/vowpalwabbit/parse_args.cc index bceb4bddbbc..acf5739949a 100644 --- a/vowpalwabbit/parse_args.cc +++ b/vowpalwabbit/parse_args.cc @@ -1053,7 +1053,7 @@ void parse_output_preds(options_i& options, vw& all) if (options.was_supplied("binary")) all.trace_message << "Warning: --raw_predictions has no defined value when --binary specified, expect no output" << endl; } - if (raw_predictions.c_str() == "stdout") + if (strcmp(raw_predictions.c_str(),"stdout")==0) all.raw_prediction = 1; //stdout else {