We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The predict_or_learn and the predict_or_learn_adf of the cbify reduction appear to be always learning, even if the flag is_learn is False, since they do not use the flag is_learn in their body. https://github.com/JohnLangford/vowpal_wabbit/blob/5e7a03d8fa37f6ce676a449461cb7635ccd5c115/vowpalwabbit/cbify.cc#L110-L111 https://github.com/JohnLangford/vowpal_wabbit/blob/5e7a03d8fa37f6ce676a449461cb7635ccd5c115/vowpalwabbit/cbify.cc#L157-L158
predict_or_learn
predict_or_learn_adf
cbify
is_learn
False
The text was updated successfully, but these errors were encountered:
You are correct here. This is easily fixed and should be.
Sorry, something went wrong.
lokitoth
No branches or pull requests
The
predict_or_learn
and thepredict_or_learn_adf
of thecbify
reduction appear to be always learning, even if the flagis_learn
isFalse
, since they do not use the flagis_learn
in their body. https://github.com/JohnLangford/vowpal_wabbit/blob/5e7a03d8fa37f6ce676a449461cb7635ccd5c115/vowpalwabbit/cbify.cc#L110-L111https://github.com/JohnLangford/vowpal_wabbit/blob/5e7a03d8fa37f6ce676a449461cb7635ccd5c115/vowpalwabbit/cbify.cc#L157-L158
The text was updated successfully, but these errors were encountered: