Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

High-level reduction cbify appears to be always learning. #1577

Closed
mdimakopoulou opened this issue Aug 23, 2018 · 1 comment
Closed

High-level reduction cbify appears to be always learning. #1577

mdimakopoulou opened this issue Aug 23, 2018 · 1 comment
Assignees
@lokitoth
Labels
Bug Bug in learning semantics, critical by default In PR There is a PR waiting to be merged for this issue

Comments

@mdimakopoulou
Copy link

The predict_or_learn and the predict_or_learn_adf of the cbify reduction appear to be always learning, even if the flag is_learn is False, since they do not use the flag is_learn in their body. https://github.com/JohnLangford/vowpal_wabbit/blob/5e7a03d8fa37f6ce676a449461cb7635ccd5c115/vowpalwabbit/cbify.cc#L110-L111
https://github.com/JohnLangford/vowpal_wabbit/blob/5e7a03d8fa37f6ce676a449461cb7635ccd5c115/vowpalwabbit/cbify.cc#L157-L158
@JohnLangford JohnLangford added the Bug Bug in learning semantics, critical by default label Dec 28, 2018
@JohnLangford
Copy link
Member

You are correct here. This is easily fixed and should be.

This was referenced Jan 22, 2019
Merged
Merged
@lokitoth lokitoth added the In PR There is a PR waiting to be merged for this issue label Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lokitoth lokitoth

Labels
Bug Bug in learning semantics, critical by default In PR There is a PR waiting to be merged for this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JohnLangford @lokitoth @mdimakopoulou