From 686b0e9f73409adc7688fdf5bac3b7b8382d45ba Mon Sep 17 00:00:00 2001
From: Jack Gerrits <jackgerrits95@gmail.com>
Date: Thu, 2 Aug 2018 12:26:21 -0400
Subject: [PATCH 1/6] Extract stable_unique function

---
 vowpalwabbit/parser_helper.cc | 36 +++++++++++++++++++++++++----------
 1 file changed, 26 insertions(+), 10 deletions(-)

diff --git a/vowpalwabbit/parser_helper.cc b/vowpalwabbit/parser_helper.cc
index 77b139081a8..6a915c5fb9a 100644
--- a/vowpalwabbit/parser_helper.cc
+++ b/vowpalwabbit/parser_helper.cc
@@ -34,6 +34,30 @@ std::vector<std::string> opts_to_args(const std::vector<boost::program_options::
   return args;
 }
 
+// Performs unique operation over collection without requiring the collection to be sorted first.
+// Returns pointer to first element after unique elements to erase from until end of collection.
+// Original ordering of elements is preserved.
+template <typename ForwardIterator>
+ForwardIterator stable_unique(ForwardIterator begin, ForwardIterator end)
+{
+  using value_t = decltype(typename std::iterator_traits<ForwardIterator>::value_type());
+
+  set<value_t> unique_set;
+
+  auto current_head = begin;
+  for (auto current_check = begin; current_check != end; current_check++)
+  {
+    if (unique_set.find(*current_check) == unique_set.end())
+    {
+      unique_set.insert(*current_check);
+      *current_head = *current_check;
+      current_head++;
+    }
+  }
+
+  return current_head;
+}
+
 // blackbox wrapping of boost program options to ignore duplicate specification of options allowed only ones, but specified multiple times
 // Behavior: only the first occurence is kept
 // Strategy: add one argument after each other until we trigger multiple_occurrences exception. Special care has to be taken of arguments to options.
@@ -59,16 +83,8 @@ po::variables_map arguments::add_options_skip_duplicates(po::options_description
               if (it.second.value().type() == typeid(vector<string>))
                 {
                   auto& values = it.second.as<vector<string>>();
-                  set<string> unique_set;
-                  auto current_head = values.begin();
-                  for (auto current_check = values.begin(); current_check != values.end(); current_check++)
-                    if (unique_set.find(*current_check) == unique_set.end())
-                      {
-                        unique_set.insert(*current_check);
-                        *current_head = *current_check;
-                        current_head++;
-                      }
-                  values.erase(current_head, values.end());
+                  auto end = stable_unique(values.begin(), values.end());
+                  values.erase(end, values.end());
                 }
             }
 

From e146b36c88547aa2a7cc1e94e452d14967afbffc Mon Sep 17 00:00:00 2001
From: Jack Gerrits <jackgerrits95@gmail.com>
Date: Thu, 2 Aug 2018 13:24:49 -0400
Subject: [PATCH 2/6] Fix unnecesarily complex type

---
 vowpalwabbit/parser_helper.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/vowpalwabbit/parser_helper.cc b/vowpalwabbit/parser_helper.cc
index 6a915c5fb9a..de2873e25f0 100644
--- a/vowpalwabbit/parser_helper.cc
+++ b/vowpalwabbit/parser_helper.cc
@@ -40,7 +40,7 @@ std::vector<std::string> opts_to_args(const std::vector<boost::program_options::
 template <typename ForwardIterator>
 ForwardIterator stable_unique(ForwardIterator begin, ForwardIterator end)
 {
-  using value_t = decltype(typename std::iterator_traits<ForwardIterator>::value_type());
+  using value_t = typename std::iterator_traits<ForwardIterator>::value_type;
 
   set<value_t> unique_set;
 

From 1a8835847567f88def9fb68e9149e053f3ab2458 Mon Sep 17 00:00:00 2001
From: Jack Gerrits <jackgerrits95@gmail.com>
Date: Fri, 3 Aug 2018 15:53:16 -0400
Subject: [PATCH 3/6] Move stable_unique to own header

---
 vowpalwabbit/parser_helper.cc | 26 +-------------------------
 vowpalwabbit/stable_unique.h  | 27 +++++++++++++++++++++++++++
 2 files changed, 28 insertions(+), 25 deletions(-)
 create mode 100644 vowpalwabbit/stable_unique.h

diff --git a/vowpalwabbit/parser_helper.cc b/vowpalwabbit/parser_helper.cc
index de2873e25f0..04210cd0e08 100644
--- a/vowpalwabbit/parser_helper.cc
+++ b/vowpalwabbit/parser_helper.cc
@@ -1,7 +1,7 @@
 #include <boost/foreach.hpp>
 #include "parser_helper.h"
 #include <iostream>
-#include <set>
+#include "stable_unique.h"
 
 using namespace std;
 
@@ -34,30 +34,6 @@ std::vector<std::string> opts_to_args(const std::vector<boost::program_options::
   return args;
 }
 
-// Performs unique operation over collection without requiring the collection to be sorted first.
-// Returns pointer to first element after unique elements to erase from until end of collection.
-// Original ordering of elements is preserved.
-template <typename ForwardIterator>
-ForwardIterator stable_unique(ForwardIterator begin, ForwardIterator end)
-{
-  using value_t = typename std::iterator_traits<ForwardIterator>::value_type;
-
-  set<value_t> unique_set;
-
-  auto current_head = begin;
-  for (auto current_check = begin; current_check != end; current_check++)
-  {
-    if (unique_set.find(*current_check) == unique_set.end())
-    {
-      unique_set.insert(*current_check);
-      *current_head = *current_check;
-      current_head++;
-    }
-  }
-
-  return current_head;
-}
-
 // blackbox wrapping of boost program options to ignore duplicate specification of options allowed only ones, but specified multiple times
 // Behavior: only the first occurence is kept
 // Strategy: add one argument after each other until we trigger multiple_occurrences exception. Special care has to be taken of arguments to options.
diff --git a/vowpalwabbit/stable_unique.h b/vowpalwabbit/stable_unique.h
new file mode 100644
index 00000000000..c4de0a29adc
--- /dev/null
+++ b/vowpalwabbit/stable_unique.h
@@ -0,0 +1,27 @@
+#pragma once
+
+#include <set>
+
+// Performs unique operation over collection without requiring the collection to be sorted first.
+// Returns pointer to first element after unique elements to erase from until end of collection.
+// Original ordering of elements is preserved.
+template <typename ForwardIterator>
+ForwardIterator stable_unique(ForwardIterator begin, ForwardIterator end)
+{
+  using value_t = typename std::iterator_traits<ForwardIterator>::value_type;
+
+  std::set<value_t> unique_set;
+
+  auto current_head = begin;
+  for (auto current_check = begin; current_check != end; current_check++)
+  {
+    if (unique_set.find(*current_check) == unique_set.end())
+    {
+      unique_set.insert(*current_check);
+      *current_head = *current_check;
+      current_head++;
+    }
+  }
+
+  return current_head;
+}
\ No newline at end of file

From 876c65f4c036bd8361e78a0689c3435c955bc58b Mon Sep 17 00:00:00 2001
From: Jack Gerrits <jackgerrits95@gmail.com>
Date: Tue, 21 Aug 2018 14:42:09 -0400
Subject: [PATCH 4/6] Add stable_unique test

---
 Makefile                              |  6 ++++-
 test/unit_test/Makefile               | 33 +++++++++++++++++++++++++++
 test/unit_test/main.cc                |  3 +++
 test/unit_test/stable_unique_tests.cc | 29 +++++++++++++++++++++++
 4 files changed, 70 insertions(+), 1 deletion(-)
 create mode 100644 test/unit_test/Makefile
 create mode 100644 test/unit_test/main.cc
 create mode 100644 test/unit_test/stable_unique_tests.cc

diff --git a/Makefile b/Makefile
index ea7045090a3..c0246e968b5 100644
--- a/Makefile
+++ b/Makefile
@@ -151,12 +151,16 @@ java: vw
 
 .FORCE:
 
-test: .FORCE vw library_example
+test: .FORCE vw library_example unit_test
 	@echo "vw running test-suite..."
 	(cd test && ./RunTests -d -fe -E 0.001 -O --onethread ../vowpalwabbit/vw)
 	(cd test && ./RunTests -d -fe -E 0.001 ../vowpalwabbit/vw)
 	cd test && python save_resume_test.py --verbose_on_fail
 
+unit_test: vw
+	cd test/unit_test; $(MAKE) -j $(NPROCS) things
+	(cd test/unit_test && ./vw-unit-test.out)
+
 test_gcov: .FORCE vw_gcov library_example_gcov
 	@echo "vw running test-suite..."
 	(cd test && ./RunTests -d -fe -E 0.001 ../vowpalwabbit/vw ../vowpalwabbit/vw)
diff --git a/test/unit_test/Makefile b/test/unit_test/Makefile
new file mode 100644
index 00000000000..6dccac8f3de
--- /dev/null
+++ b/test/unit_test/Makefile
@@ -0,0 +1,33 @@
+TARGET = vw-unit-test.out
+
+VW_LIB = -L../../vowpalwabbit -lvw -lallreduce
+BOOST_LIBS = -lboost_unit_test_framework -lboost_system
+ALL_LIBS = $(VW_LIB) $(BOOST_LIBS) $(LIBS)
+
+INCLUDE = -I ../../vowpalwabbit -I ../../explore
+
+.PHONY: default all clean
+
+default: $(TARGET)
+all: default
+
+things: all
+
+SOURCES = $(wildcard *.cc)
+OBJECTS = $(patsubst %.cc, %.o, $(SOURCES))
+HEADERS = $(wildcard *.h)
+
+%.o: %.cc $(HEADERS)
+	$(CXX) $(FLAGS) $(INCLUDE) -c $< -o $@
+
+.PRECIOUS: $(TARGET) $(OBJECTS)
+
+$(info $$SOURCES is [${SOURCES}])
+$(info $$OBJECTS is [${OBJECTS}])
+
+$(TARGET): $(OBJECTS)
+	$(CXX) $(FLAGS) $(OBJECTS) $(LIBDIR) $(ALL_LIBS) -Wall -o $@
+
+clean:
+	-rm -f *.o
+	-rm -f $(TARGET)
diff --git a/test/unit_test/main.cc b/test/unit_test/main.cc
new file mode 100644
index 00000000000..95489cab72b
--- /dev/null
+++ b/test/unit_test/main.cc
@@ -0,0 +1,3 @@
+#define BOOST_TEST_DYN_LINK
+#define BOOST_TEST_MODULE Main
+#include <boost/test/unit_test.hpp>
diff --git a/test/unit_test/stable_unique_tests.cc b/test/unit_test/stable_unique_tests.cc
new file mode 100644
index 00000000000..7b7a9ef4e79
--- /dev/null
+++ b/test/unit_test/stable_unique_tests.cc
@@ -0,0 +1,29 @@
+#define BOOST_TEST_DYN_LINK
+
+#include <boost/test/unit_test.hpp>
+#include <boost/test/test_tools.hpp>
+
+#include <vector>
+#include <algorithm>
+
+#include "stable_unique.h"
+
+BOOST_AUTO_TEST_CASE(stable_unique_sorted)
+{
+  std::vector<int> v = {1,1,2,2,2,6,78,89,89};
+  std::vector<int> expected = {1,2,6,78,89};
+
+  v.erase(stable_unique(v.begin(), v.end()), v.end());
+
+  BOOST_CHECK_EQUAL_COLLECTIONS(v.begin(), v.end(), expected.begin(), expected.end());
+}
+
+BOOST_AUTO_TEST_CASE(stable_unique_unsorted)
+{
+  std::vector<int> v = {45,65,76,23,45,11,34,23,45,-34,-1,22,23,22,0,0,11,23,109};
+  std::vector<int> expected = {45,65,76,23,11,34,-34,-1,22,0,109};
+
+  v.erase(stable_unique(v.begin(), v.end()), v.end());
+
+  BOOST_CHECK_EQUAL_COLLECTIONS(v.begin(), v.end(), expected.begin(), expected.end());
+}

From 97ef42708698356d4e3c32409d88296ff24c04f7 Mon Sep 17 00:00:00 2001
From: Jack Gerrits <jackgerrits95@gmail.com>
Date: Tue, 21 Aug 2018 15:45:29 -0400
Subject: [PATCH 5/6] add project to vw.sln for unit tests

---
 .../unit_test/unit_test.vcxproj               |   2 +-
 test/unit_test/packages.config                |   6 +
 test/unit_test/stable_unique_tests.cc         |   1 -
 test/unit_test/unit_test.vcxproj              | 192 ++++++++++++++++++
 test/unit_test/unit_test.vcxproj.filters      |  28 +++
 vowpalwabbit/vw.sln                           |  18 ++
 6 files changed, 245 insertions(+), 2 deletions(-)
 create mode 100644 test/unit_test/packages.config
 create mode 100644 test/unit_test/unit_test.vcxproj
 create mode 100644 test/unit_test/unit_test.vcxproj.filters

diff --git a/reinforcement_learning/unit_test/unit_test.vcxproj b/reinforcement_learning/unit_test/unit_test.vcxproj
index e2bee18ea27..56c5e586704 100644
--- a/reinforcement_learning/unit_test/unit_test.vcxproj
+++ b/reinforcement_learning/unit_test/unit_test.vcxproj
@@ -203,4 +203,4 @@
     <Error Condition="!Exists('..\..\vowpalwabbit\packages\boost_program_options-vc140.1.63.0.0\build\native\boost_program_options-vc140.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\vowpalwabbit\packages\boost_program_options-vc140.1.63.0.0\build\native\boost_program_options-vc140.targets'))" />
     <Error Condition="!Exists('..\..\vowpalwabbit\packages\boost_unit_test_framework-vc140.1.63.0.0\build\native\boost_unit_test_framework-vc140.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\vowpalwabbit\packages\boost_unit_test_framework-vc140.1.63.0.0\build\native\boost_unit_test_framework-vc140.targets'))" />
   </Target>
-</Project>
\ No newline at end of file
+</Project>
diff --git a/test/unit_test/packages.config b/test/unit_test/packages.config
new file mode 100644
index 00000000000..26c6edfbc3b
--- /dev/null
+++ b/test/unit_test/packages.config
@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="utf-8"?>
+<packages>
+  <package id="boost" version="1.63.0.0" targetFramework="native" />
+  <package id="boost_program_options-vc140" version="1.63.0.0" targetFramework="native" />
+  <package id="boost_unit_test_framework-vc140" version="1.63.0.0" targetFramework="native" />
+</packages>
\ No newline at end of file
diff --git a/test/unit_test/stable_unique_tests.cc b/test/unit_test/stable_unique_tests.cc
index 7b7a9ef4e79..2fc3ece8174 100644
--- a/test/unit_test/stable_unique_tests.cc
+++ b/test/unit_test/stable_unique_tests.cc
@@ -4,7 +4,6 @@
 #include <boost/test/test_tools.hpp>
 
 #include <vector>
-#include <algorithm>
 
 #include "stable_unique.h"
 
diff --git a/test/unit_test/unit_test.vcxproj b/test/unit_test/unit_test.vcxproj
new file mode 100644
index 00000000000..212ed078ae5
--- /dev/null
+++ b/test/unit_test/unit_test.vcxproj
@@ -0,0 +1,192 @@
+<?xml version="1.0" encoding="utf-8"?>
+<Project DefaultTargets="Build" ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+  <ItemGroup Label="ProjectConfigurations">
+    <ProjectConfiguration Include="Debug|Win32">
+      <Configuration>Debug</Configuration>
+      <Platform>Win32</Platform>
+    </ProjectConfiguration>
+    <ProjectConfiguration Include="Debug|x64">
+      <Configuration>Debug</Configuration>
+      <Platform>x64</Platform>
+    </ProjectConfiguration>
+    <ProjectConfiguration Include="Release|Win32">
+      <Configuration>Release</Configuration>
+      <Platform>Win32</Platform>
+    </ProjectConfiguration>
+    <ProjectConfiguration Include="Release|x64">
+      <Configuration>Release</Configuration>
+      <Platform>x64</Platform>
+    </ProjectConfiguration>
+  </ItemGroup>
+  <ItemGroup>
+    <ClCompile Include="main.cc" />
+    <ClCompile Include="stable_unique_tests.cc" />
+  </ItemGroup>
+  <ItemGroup>
+    <None Include="packages.config" />
+  </ItemGroup>
+  <ItemGroup>
+    <ProjectReference Include="..\..\vowpalwabbit\vw_dynamic.vcxproj">
+      <Project>{1e205806-7f80-47dd-a38d-fc08083f3593}</Project>
+    </ProjectReference>
+  </ItemGroup>
+  <PropertyGroup Label="Globals">
+    <ProjectGuid>{E02E3869-D9AD-4513-B352-93F90B7D6FE3}</ProjectGuid>
+    <Keyword>Win32Proj</Keyword>
+    <RootNamespace>unit_test</RootNamespace>
+    <ProjectName>vw_unit_test</ProjectName>
+    <WindowsTargetPlatformVersion>8.1</WindowsTargetPlatformVersion>
+  </PropertyGroup>
+  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'" Label="Configuration">
+    <ConfigurationType>Application</ConfigurationType>
+    <UseDebugLibraries>true</UseDebugLibraries>
+    <PlatformToolset>v140</PlatformToolset>
+    <CharacterSet>Unicode</CharacterSet>
+  </PropertyGroup>
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'" Label="Configuration">
+    <ConfigurationType>Application</ConfigurationType>
+    <UseDebugLibraries>false</UseDebugLibraries>
+    <PlatformToolset>v140</PlatformToolset>
+    <WholeProgramOptimization>true</WholeProgramOptimization>
+    <CharacterSet>Unicode</CharacterSet>
+  </PropertyGroup>
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'" Label="Configuration">
+    <ConfigurationType>Application</ConfigurationType>
+    <UseDebugLibraries>true</UseDebugLibraries>
+    <PlatformToolset>v140</PlatformToolset>
+    <CharacterSet>Unicode</CharacterSet>
+  </PropertyGroup>
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'" Label="Configuration">
+    <ConfigurationType>Application</ConfigurationType>
+    <UseDebugLibraries>false</UseDebugLibraries>
+    <PlatformToolset>v140</PlatformToolset>
+    <WholeProgramOptimization>true</WholeProgramOptimization>
+    <CharacterSet>Unicode</CharacterSet>
+  </PropertyGroup>
+  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.props" />
+  <ImportGroup Label="ExtensionSettings">
+  </ImportGroup>
+  <ImportGroup Label="PropertySheets" Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
+    <Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
+  </ImportGroup>
+  <ImportGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'" Label="PropertySheets">
+    <Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
+  </ImportGroup>
+  <ImportGroup Label="PropertySheets" Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
+    <Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
+  </ImportGroup>
+  <ImportGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'" Label="PropertySheets">
+    <Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
+  </ImportGroup>
+  <PropertyGroup Label="UserMacros" />
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
+    <LinkIncremental>true</LinkIncremental>
+    <IntDir>$(Platform)\$(Configuration)\</IntDir>
+    <OutDir>$(SolutionDir)$(Platform)\$(Configuration)\</OutDir>
+  </PropertyGroup>
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
+    <LinkIncremental>true</LinkIncremental>
+  </PropertyGroup>
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
+    <LinkIncremental>false</LinkIncremental>
+    <IntDir>$(Platform)\$(Configuration)\</IntDir>
+    <OutDir>$(SolutionDir)$(Platform)\$(Configuration)\</OutDir>
+  </PropertyGroup>
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
+    <LinkIncremental>false</LinkIncremental>
+  </PropertyGroup>
+  <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
+    <ClCompile>
+      <PrecompiledHeader>Use</PrecompiledHeader>
+      <WarningLevel>Level3</WarningLevel>
+      <Optimization>Disabled</Optimization>
+      <PreprocessorDefinitions>WIN32;_DEBUG;_CONSOLE;%(PreprocessorDefinitions)</PreprocessorDefinitions>
+      <SDLCheck>true</SDLCheck>
+    </ClCompile>
+    <Link>
+      <SubSystem>Console</SubSystem>
+      <GenerateDebugInformation>true</GenerateDebugInformation>
+    </Link>
+  </ItemDefinitionGroup>
+  <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
+    <ClCompile>
+      <PrecompiledHeader>NotUsing</PrecompiledHeader>
+      <WarningLevel>Level3</WarningLevel>
+      <Optimization>Disabled</Optimization>
+      <PreprocessorDefinitions>WIN32;_DEBUG;_CONSOLE;%(PreprocessorDefinitions)</PreprocessorDefinitions>
+      <SDLCheck>true</SDLCheck>
+    </ClCompile>
+    <Link>
+      <SubSystem>Console</SubSystem>
+      <GenerateDebugInformation>true</GenerateDebugInformation>
+    </Link>
+  </ItemDefinitionGroup>
+  <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
+    <ClCompile>
+      <WarningLevel>Level3</WarningLevel>
+      <PrecompiledHeader>Use</PrecompiledHeader>
+      <Optimization>MaxSpeed</Optimization>
+      <FunctionLevelLinking>true</FunctionLevelLinking>
+      <IntrinsicFunctions>true</IntrinsicFunctions>
+      <PreprocessorDefinitions>WIN32;NDEBUG;_CONSOLE;%(PreprocessorDefinitions)</PreprocessorDefinitions>
+      <SDLCheck>true</SDLCheck>
+    </ClCompile>
+    <Link>
+      <SubSystem>Console</SubSystem>
+      <GenerateDebugInformation>true</GenerateDebugInformation>
+      <EnableCOMDATFolding>true</EnableCOMDATFolding>
+      <OptimizeReferences>true</OptimizeReferences>
+    </Link>
+  </ItemDefinitionGroup>
+  <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
+    <ClCompile>
+      <WarningLevel>Level3</WarningLevel>
+      <PrecompiledHeader>Use</PrecompiledHeader>
+      <Optimization>MaxSpeed</Optimization>
+      <FunctionLevelLinking>true</FunctionLevelLinking>
+      <IntrinsicFunctions>true</IntrinsicFunctions>
+      <PreprocessorDefinitions>WIN32;NDEBUG;_CONSOLE;%(PreprocessorDefinitions)</PreprocessorDefinitions>
+      <SDLCheck>true</SDLCheck>
+    </ClCompile>
+    <Link>
+      <SubSystem>Console</SubSystem>
+      <GenerateDebugInformation>true</GenerateDebugInformation>
+      <EnableCOMDATFolding>true</EnableCOMDATFolding>
+      <OptimizeReferences>true</OptimizeReferences>
+    </Link>
+  </ItemDefinitionGroup>
+  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
+  <ImportGroup Label="ExtensionTargets">
+  </ImportGroup>
+  <ItemDefinitionGroup>
+    <ClCompile>
+      <AdditionalIncludeDirectories>$(SolutionDir);%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
+    </ClCompile>
+    <Link>
+      <AdditionalLibraryDirectories>%(AdditionalLibraryDirectories)</AdditionalLibraryDirectories>
+    </Link>
+  </ItemDefinitionGroup>
+  <ImportGroup Label="ExtensionTargets">
+    <Import Project="..\..\vowpalwabbit\packages\boost.1.63.0.0\build\native\boost.targets" Condition="Exists('..\..\vowpalwabbit\packages\boost.1.63.0.0\build\native\boost.targets')" />
+    <Import Project="..\..\vowpalwabbit\packages\boost_program_options-vc140.1.63.0.0\build\native\boost_program_options-vc140.targets" Condition="Exists('..\..\vowpalwabbit\packages\boost_program_options-vc140.1.63.0.0\build\native\boost_program_options-vc140.targets')" />
+    <Import Project="..\..\vowpalwabbit\packages\boost_unit_test_framework-vc140.1.63.0.0\build\native\boost_unit_test_framework-vc140.targets" Condition="Exists('..\..\vowpalwabbit\packages\boost_unit_test_framework-vc140.1.63.0.0\build\native\boost_unit_test_framework-vc140.targets')" />
+  </ImportGroup>
+  <Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
+    <PropertyGroup>
+      <ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them.  For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
+    </PropertyGroup>
+    <Error Condition="!Exists('..\..\vowpalwabbit\packages\boost.1.63.0.0\build\native\boost.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\vowpalwabbit\packages\boost.1.63.0.0\build\native\boost.targets'))" />
+    <Error Condition="!Exists('..\..\vowpalwabbit\packages\boost_program_options-vc140.1.63.0.0\build\native\boost_program_options-vc140.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\vowpalwabbit\packages\boost_program_options-vc140.1.63.0.0\build\native\boost_program_options-vc140.targets'))" />
+    <Error Condition="!Exists('..\..\vowpalwabbit\packages\boost_unit_test_framework-vc140.1.63.0.0\build\native\boost_unit_test_framework-vc140.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\vowpalwabbit\packages\boost_unit_test_framework-vc140.1.63.0.0\build\native\boost_unit_test_framework-vc140.targets'))" />
+  </Target>
+  <ItemDefinitionGroup>
+    <ClCompile>
+      <PreprocessorDefinitions>%(PreprocessorDefinitions)</PreprocessorDefinitions>
+      <UseFullPaths Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">true</UseFullPaths>
+      <UseFullPaths Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">true</UseFullPaths>
+      <UseFullPaths Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">true</UseFullPaths>
+      <UseFullPaths Condition="'$(Configuration)|$(Platform)'=='Release|x64'">true</UseFullPaths>
+    </ClCompile>
+  </ItemDefinitionGroup>
+</Project>
\ No newline at end of file
diff --git a/test/unit_test/unit_test.vcxproj.filters b/test/unit_test/unit_test.vcxproj.filters
new file mode 100644
index 00000000000..8177266bee9
--- /dev/null
+++ b/test/unit_test/unit_test.vcxproj.filters
@@ -0,0 +1,28 @@
+<?xml version="1.0" encoding="utf-8"?>
+<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+  <ItemGroup>
+    <Filter Include="Source Files">
+      <UniqueIdentifier>{4FC737F1-C7A5-4376-A066-2A32D752A2FF}</UniqueIdentifier>
+      <Extensions>cpp;c;cc;cxx;def;odl;idl;hpj;bat;asm;asmx</Extensions>
+    </Filter>
+    <Filter Include="Header Files">
+      <UniqueIdentifier>{93995380-89BD-4b04-88EB-625FBE52EBFB}</UniqueIdentifier>
+      <Extensions>h;hpp;hxx;hm;inl;inc;xsd</Extensions>
+    </Filter>
+    <Filter Include="Resource Files">
+      <UniqueIdentifier>{67DA6AB6-F800-4c08-8B7A-83BB121AAD01}</UniqueIdentifier>
+      <Extensions>rc;ico;cur;bmp;dlg;rc2;rct;bin;rgs;gif;jpg;jpeg;jpe;resx;tiff;tif;png;wav;mfcribbon-ms</Extensions>
+    </Filter>
+  </ItemGroup>
+  <ItemGroup>
+    <ClCompile Include="main.cc">
+      <Filter>Source Files</Filter>
+    </ClCompile>
+    <ClCompile Include="stable_unique_tests.cc">
+      <Filter>Source Files</Filter>
+    </ClCompile>
+  </ItemGroup>
+  <ItemGroup>
+    <None Include="packages.config" />
+  </ItemGroup>
+</Project>
\ No newline at end of file
diff --git a/vowpalwabbit/vw.sln b/vowpalwabbit/vw.sln
index 48eaf480437..96887433034 100644
--- a/vowpalwabbit/vw.sln
+++ b/vowpalwabbit/vw.sln
@@ -92,6 +92,8 @@ Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "rl_sim_cpp", "..\reinforcem
 EndProject
 Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "test_cpp", "..\reinforcement_learning\examples\test_cpp\test_cpp.vcxproj", "{47259EFF-C4C2-4F8D-AE67-1FA6F6D5D9FE}"
 EndProject
+Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "unit_test", "..\test\unit_test\unit_test.vcxproj", "{E02E3869-D9AD-4513-B352-93F90B7D6FE3}"
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
@@ -527,6 +529,22 @@ Global
 		{47259EFF-C4C2-4F8D-AE67-1FA6F6D5D9FE}.Release|x64.Build.0 = Release|x64
 		{47259EFF-C4C2-4F8D-AE67-1FA6F6D5D9FE}.Release|x86.ActiveCfg = Release|Win32
 		{47259EFF-C4C2-4F8D-AE67-1FA6F6D5D9FE}.Release|x86.Build.0 = Release|Win32
+		{E02E3869-D9AD-4513-B352-93F90B7D6FE3}.Debug|Any CPU.ActiveCfg = Debug|Win32
+		{E02E3869-D9AD-4513-B352-93F90B7D6FE3}.Debug|x64.ActiveCfg = Debug|x64
+		{E02E3869-D9AD-4513-B352-93F90B7D6FE3}.Debug|x64.Build.0 = Debug|x64
+		{E02E3869-D9AD-4513-B352-93F90B7D6FE3}.Debug|x86.ActiveCfg = Debug|Win32
+		{E02E3869-D9AD-4513-B352-93F90B7D6FE3}.Debug|x86.Build.0 = Debug|Win32
+		{E02E3869-D9AD-4513-B352-93F90B7D6FE3}.DebugLeakCheck|Any CPU.ActiveCfg = Release|x64
+		{E02E3869-D9AD-4513-B352-93F90B7D6FE3}.DebugLeakCheck|Any CPU.Build.0 = Release|x64
+		{E02E3869-D9AD-4513-B352-93F90B7D6FE3}.DebugLeakCheck|x64.ActiveCfg = Debug|x64
+		{E02E3869-D9AD-4513-B352-93F90B7D6FE3}.DebugLeakCheck|x64.Build.0 = Debug|x64
+		{E02E3869-D9AD-4513-B352-93F90B7D6FE3}.DebugLeakCheck|x86.ActiveCfg = Debug|Win32
+		{E02E3869-D9AD-4513-B352-93F90B7D6FE3}.DebugLeakCheck|x86.Build.0 = Debug|Win32
+		{E02E3869-D9AD-4513-B352-93F90B7D6FE3}.Release|Any CPU.ActiveCfg = Release|Win32
+		{E02E3869-D9AD-4513-B352-93F90B7D6FE3}.Release|x64.ActiveCfg = Release|x64
+		{E02E3869-D9AD-4513-B352-93F90B7D6FE3}.Release|x64.Build.0 = Release|x64
+		{E02E3869-D9AD-4513-B352-93F90B7D6FE3}.Release|x86.ActiveCfg = Release|Win32
+		{E02E3869-D9AD-4513-B352-93F90B7D6FE3}.Release|x86.Build.0 = Release|Win32
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE

From 214cd01b9dc0e3a781cf450f9e23ed40a5edd458 Mon Sep 17 00:00:00 2001
From: Jack Gerrits <jackgerrits95@gmail.com>
Date: Tue, 21 Aug 2018 21:04:26 -0400
Subject: [PATCH 6/6] Remove precompiled header from all configurations

---
 test/unit_test/unit_test.vcxproj | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/test/unit_test/unit_test.vcxproj b/test/unit_test/unit_test.vcxproj
index 212ed078ae5..4995ce0da3b 100644
--- a/test/unit_test/unit_test.vcxproj
+++ b/test/unit_test/unit_test.vcxproj
@@ -98,7 +98,7 @@
   </PropertyGroup>
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
     <ClCompile>
-      <PrecompiledHeader>Use</PrecompiledHeader>
+      <PrecompiledHeader></PrecompiledHeader>
       <WarningLevel>Level3</WarningLevel>
       <Optimization>Disabled</Optimization>
       <PreprocessorDefinitions>WIN32;_DEBUG;_CONSOLE;%(PreprocessorDefinitions)</PreprocessorDefinitions>
@@ -111,7 +111,8 @@
   </ItemDefinitionGroup>
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
     <ClCompile>
-      <PrecompiledHeader>NotUsing</PrecompiledHeader>
+      <PrecompiledHeader>
+      </PrecompiledHeader>
       <WarningLevel>Level3</WarningLevel>
       <Optimization>Disabled</Optimization>
       <PreprocessorDefinitions>WIN32;_DEBUG;_CONSOLE;%(PreprocessorDefinitions)</PreprocessorDefinitions>
@@ -125,7 +126,7 @@
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
     <ClCompile>
       <WarningLevel>Level3</WarningLevel>
-      <PrecompiledHeader>Use</PrecompiledHeader>
+      <PrecompiledHeader></PrecompiledHeader>
       <Optimization>MaxSpeed</Optimization>
       <FunctionLevelLinking>true</FunctionLevelLinking>
       <IntrinsicFunctions>true</IntrinsicFunctions>
@@ -142,7 +143,7 @@
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
     <ClCompile>
       <WarningLevel>Level3</WarningLevel>
-      <PrecompiledHeader>Use</PrecompiledHeader>
+      <PrecompiledHeader></PrecompiledHeader>
       <Optimization>MaxSpeed</Optimization>
       <FunctionLevelLinking>true</FunctionLevelLinking>
       <IntrinsicFunctions>true</IntrinsicFunctions>
@@ -189,4 +190,4 @@
       <UseFullPaths Condition="'$(Configuration)|$(Platform)'=='Release|x64'">true</UseFullPaths>
     </ClCompile>
   </ItemDefinitionGroup>
-</Project>
\ No newline at end of file
+</Project>