fix: explore_eval don't learn if logged action not in predicted actions #4262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olgavrou
commented
Nov 2, 2022
| @@ -164,6 +165,8 @@ void do_actual_learning(explore_eval& data, multi_learner& base, VW::multi_ex& e | |||
| if (data.known_cost.action == a_s[i].action) { action_probability = a_s[i].score; } | |||
| } | |||
|
|
|||
| if (action_probability == 0) { return; } | |||
|
|
|||
| float threshold = action_probability / data.known_cost.probability; | |||
|
|
|||
| if (!data.fixed_multiplier) { data.multiplier = std::min(data.multiplier, 1 / threshold); } | |||
There was a problem hiding this comment.
now that probs can be zero, this 1 / threshold could cause division by zero
jackgerrits
reviewed
Nov 2, 2022
Co-authored-by: Jack Gerrits <jackgerrits@users.noreply.github.com>
olgavrou
changed the title
ataymano
approved these changes
Nov 8, 2022
jackgerrits
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.