Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: This patches a bug with flat_example collision cleanup #4265

Merged
merged 12 commits into from
Nov 7, 2022
Merged

fix: This patches a bug with flat_example collision cleanup #4265

merged 12 commits into from
Nov 7, 2022

Commits on Nov 3, 2022

  1. Fixed a bug with flat example collision cleanup. Added two unit tests… 

    … for the old bug.
    @mrucker
    mrucker committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    b6b1ffd View commit details
    Browse the repository at this point in the history

  2. Fixed a documentation typo.

    @mrucker
    mrucker committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    ea92af1 View commit details
    Browse the repository at this point in the history

  3. Update vowpalwabbit/core/tests/flat_example_test.cc 

    Co-authored-by: Jack Gerrits <jackgerrits@users.noreply.github.com>
    @mrucker @jackgerrits
    mrucker and jackgerrits authored Nov 3, 2022
    Configuration menu
    Copy the full SHA
    819ddaa View commit details
    Browse the repository at this point in the history

  4. Update vowpalwabbit/core/tests/flat_example_test.cc 

    Co-authored-by: Jack Gerrits <jackgerrits@users.noreply.github.com>
    @mrucker @jackgerrits
    mrucker and jackgerrits authored Nov 3, 2022
    Configuration menu
    Copy the full SHA
    be4697f View commit details
    Browse the repository at this point in the history

  5. fix test output

    @jackgerrits
    jackgerrits committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    83f6927 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. finish example

    @jackgerrits
    jackgerrits committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    c666ce0 View commit details
    Browse the repository at this point in the history

  2. free the flat example

    @jackgerrits
    jackgerrits committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    dd13cad View commit details
    Browse the repository at this point in the history

  3. fix tests

    @jackgerrits
    jackgerrits committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    852a1ae View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into fix_flat_collision

    @jackgerrits
    jackgerrits authored Nov 4, 2022
    Configuration menu
    Copy the full SHA
    c0871cb View commit details
    Browse the repository at this point in the history

  5. Use make_args

    @jackgerrits
    jackgerrits committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    b1d0faf View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. test diff

    @jackgerrits
    jackgerrits committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    6499c8c View commit details
    Browse the repository at this point in the history

  2. update test

    @jackgerrits
    jackgerrits committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    719e1ea View commit details
    Browse the repository at this point in the history