feat: Add avx2 implementation for one pass svd in large action spaces. #4281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwd-ms
changed the title
olgavrou
reviewed
Dec 1, 2022
| red_features.generated_interactions ? *red_features.generated_interactions : *ex->interactions; | ||
| for (const auto& ns : interactions) | ||
| { | ||
| // TODO: other interactions, ignores & extent_interactions. The following only handles quadratics. |
There was a problem hiding this comment.
should we emit some sort of warning if users select LAS + simd + ignore/extend/cubics/other instead of silently ignoring?
There was a problem hiding this comment.
yes, let me handle these and add warnings and some tests in a separate pr.
olgavrou
approved these changes
Dec 1, 2022
|
@zwd-ms Did you benchmark the performance improvement of using |
@rami-lv yes we see good perf speed up for an expensive part in cb_las, but for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.