Few more framework-demo tweaks; throw error when missing components

VulcanJS · Feb 19, 2017 · ba32f42 · ba32f42
1 parent a658e78
commit ba32f42
Show file tree

Hide file tree

Showing 8 changed files with 6 additions and 52 deletions.
diff --git a/...ramework-demo/lib/components/Accounts.jsx → ...work-demo/lib/components/AccountsForm.jsx b/...ramework-demo/lib/components/Accounts.jsx → ...work-demo/lib/components/AccountsForm.jsx
diff --git a/packages/framework-demo/lib/fragments.js b/packages/framework-demo/lib/fragments.js
diff --git a/packages/framework-demo/lib/modules/components.js b/packages/framework-demo/lib/modules/components.js
@@ -1,4 +1,4 @@
-import '../components/Accounts.jsx';
+import '../components/AccountsForm.jsx';
 import '../components/MoviesDetails.jsx';
 import '../components/MoviesEditForm.jsx';
 import '../components/MoviesItem.jsx';

diff --git a/packages/framework-demo/lib/modules/permissions.js b/packages/framework-demo/lib/modules/permissions.js
@@ -1,11 +1,5 @@
 import Users from 'meteor/nova:users';
 
-const guestsActions = [
-  'movies.view.own',
-  'movies.view.all',
-];
-Users.groups.guests.can(membersActions);
-
 const membersActions = [
   'movies.new',
   'movies.edit.own',

diff --git a/packages/framework-demo/lib/modules/resolvers.js b/packages/framework-demo/lib/modules/resolvers.js
@@ -27,7 +27,7 @@ const resolvers = {
 
     name: 'moviesList',
 
-    resolver(root, {terms}, context, info) {
+    resolver(root, {terms = {}}, context, info) {
       let {selector, options} = context.Movies.getParameters(terms);
       options.limit = (terms.limit < 1 || terms.limit > 100) ? 100 : terms.limit;
       options.fields = context.getViewableFields(context.currentUser, context.Movies);
@@ -51,7 +51,7 @@ const resolvers = {
 
     name: 'moviesTotal',
 
-    resolver(root, {terms}, context) {
+    resolver(root, {terms = {}}, context) {
       let {selector, options} = context.Movies.getParameters(terms);
       return context.Movies.find(selector, options).count();
     },

diff --git a/packages/nova-base-components/lib/common/Error404.jsx b/packages/nova-base-components/lib/common/Error404.jsx
diff --git a/packages/nova-base-components/lib/components.js b/packages/nova-base-components/lib/components.js
@@ -11,7 +11,6 @@ import './common/FlashMessages.jsx';
 import './common/Newsletter.jsx';
 import './common/NewsletterButton.jsx';
 import './common/SearchForm.jsx';
-import './common/Error404.jsx';
 import './common/Vote.jsx';
 
 // posts

diff --git a/packages/nova-lib/lib/modules/components.js b/packages/nova-lib/lib/modules/components.js
@@ -47,6 +47,9 @@ export const registerComponent = (name, rawComponent, ...hocs) => {
  */
 export const getComponent = (name) => {
   const component = ComponentsTable[name];
+  if (!component) {
+    throw new Error(`Component ${name} not registered.`)
+  }
   const hocs = component.hocs.map(hoc => Array.isArray(hoc) ? hoc[0](hoc[1]) : hoc);
   return compose(...hocs)(component.rawComponent)
 };