-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fatal exception. Bad notification for startForeground. #59
Comments
Thanks for the report @dtuite. Do you think you could submit a PR? |
I just had a look at the Java files you have in here and honestly I doubt I can. I don't know any Java or anything about native android libraries really so it would probably take me weeks to learn and follow through all the docs. If I could see a simple way to modify |
@dtuite I talked with the team and we don't have the bandwidth to prioritize diagnosing and fixing this exception at the moment; however, if |
Ready for review. |
@TSMMark @dtuite Would be nice if this library auto checked the See: https://facebook.github.io/react-native/docs/platform-specific-code.html |
@watadarkstar Good idea! PRs welcome :) |
If I have some time I'll tackle this @TSMMark but no promises 🙏 |
@watadarkstar @TSMMark how about we turn off notifications by default? We'd have to do a major version bump and release notes but it's a very easy fix. |
@StevePotter I'd prefer that they were on by default and disabled on APK 27 and greater automatically. Seems like a cleaner experience and probably still very little work (a one or two liner). |
Using APK 28. After searching and searching I finally found this thread. I turned notification off. Now the app doesn't crash. Instead, it throws this error: |
Running into the same issue as @peterent. Had to keep |
This exception occurs in SDK 27 (Android 8.1) but not in lower SDK versions.
Turning off notifications prevents the exception from occurring.
The issue appears to be fairly common and widely document for other libraries. I believe this is the same issue on SO.
I don't have a reproduction available but I believe there is one in an issue on this other upload library
The text was updated successfully, but these errors were encountered: