Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How shall I create the file "test.src"? #5

Open
mriganktiwari opened this issue Dec 29, 2020 · 7 comments
Open

How shall I create the file "test.src"? #5

mriganktiwari opened this issue Dec 29, 2020 · 7 comments

Comments

@mriganktiwari
Copy link

How shall I create the file "test.src" at question generation step? And does it contain?

@sonsus
Copy link

sonsus commented Mar 18, 2021

@mriganktiwari I guess i t's from the part preparing (tokenize and binarize) the inputs for QG model that corresponds to P(Q|Y). So I thought this should be test.tgt of CNN/DM dataset (and thus doing so)

Correct me if I'm wrong =]

@sonsus
Copy link

sonsus commented Mar 19, 2021

@mriganktiwari I found that I need to tokenize and binarize test_w_10ans.txt instead of original test-tgt split= test.txt.tgt.tagged to make up 100 questions per test split sample (that is doc-summary pair).

I guess the annotation of P(Q|Y) was a good idea to avoid misleading the readers of what QAGS measuring, but, to reproduce, this leaves a question mark. Shouldn't it be P(Q|Y;A) ? @W4ngatang

@Zhou-Zoey
Copy link

How shall I create the file "test.src" at question generation step? And does it contain?

Have you figured out it? When reproducing this work, I was also confused by this problem

@Zhou-Zoey
Copy link

@mriganktiwari I found that I need to tokenize and binarize test_w_10ans.txt instead of original test-tgt split= test.txt.tgt.tagged to make up 100 questions per test split sample (that is doc-summary pair).

I guess the annotation of P(Q|Y) was a good idea to avoid misleading the readers of what QAGS measuring, but, to reproduce, this leaves a question mark. Shouldn't it be P(Q|Y;A) ? @W4ngatang

Do you mean that the test_w_10ans.txt is the only file that need to be tokenized?

@dlaredo
Copy link

dlaredo commented Sep 4, 2023

Any new information on this one? I also dont know how to generate this file

@sonsus
Copy link

sonsus commented Sep 26, 2023

@mriganktiwari I found that I need to tokenize and binarize test_w_10ans.txt instead of original test-tgt split= test.txt.tgt.tagged to make up 100 questions per test split sample (that is doc-summary pair).

I guess the annotation of P(Q|Y) was a good idea to avoid misleading the readers of what QAGS measuring, but, to reproduce, this leaves a question mark. Shouldn't it be P(Q|Y;A) ? @W4ngatang

I don't really remember the details of the code but I succeeded reproducing it after writing the comment now I'm referring to. Feel sorry that I cannot share actual code (which is lost) I've run for the experiment. But if you want to reproduce it, the original author's code is worth reading if you already read the paper. It was a good starting point for me and took not too long to fill the gap. If you replace the generation models in this work with recent language models, it will definitely work better. IMHO, if I need to revisit this work, I wouldn't bother myself to train small models as the original work did but just adapt the instruct-tuned LLMs instead with some good instructions. @dlaredo @Zhou-Zoey

@sonsus
Copy link

sonsus commented Sep 26, 2023

Hope my mail with the author might help you to reproduce it or in some other way.
Screenshot_20230927_041702_Gmail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants