This fixes items which are not an issue, and breaks things in some files.

Can you explain which files are broken?

Without this fix, the plugin will never be translated the right way.

@bastienho you made blanket find/replace changes to files that have nothing to do with the text domain.

As I've checked you are correct that there appears to have been a long standing misunderstanding with the requirements for the text domain which are clear that it must match the plugin slug.

So while this does in fact need to be fixed it can't be blindly done using a global find/replace. As you should see clearly the GitHub repository isn't the same as the plugin slug. Changing things in README files and the GitHub Actions for CI/CD should not be done.

My bad.

I've checked the plugin locally and didn't see any broks, but in fact, I haven't teststed CI/CD stuff.

I'll take a look for a more accurate replacement.

I'm working on some development environment and a build updates. It's a simple matter of changing the main text domain specified and running the npm run check:i18n and the places that need an update will be reported. I've made the appropriate changes in my pending changes.