Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: various BountyPanel bugs #1156

Merged
merged 3 commits into from
Feb 1, 2024
Merged

fix: various BountyPanel bugs #1156

merged 3 commits into from
Feb 1, 2024

Conversation

HKayn
Copy link
Contributor

@HKayn HKayn commented Jan 31, 2024

Summary:

This includes the following fixes for bounty panels:

  • Directly clicking on the chevron in a table row now correctly expands and closes the details.
  • Rapidly clicking on table rows now expands and closes the details instead of selecting the text.
    • I tried preserving text selection in detail rows, but for some reason, the entire table becomes unresponsive when there's an active selection in a detail row.

Neither feat nor fix:

  • An unused table slot in BountyPanel has been removed.

Mockups, screenshots, evidence:

Footage of the chevron click bug:
https://github.com/WFCD/warframe-hub/assets/65450174/2a836213-7e05-4a8e-bdab-d56c61914f79

@HKayn HKayn requested a review from a team as a code owner January 31, 2024 20:20
@HKayn HKayn requested a review from EricSihaoLin January 31, 2024 20:20
Copy link

vercel bot commented Jan 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
warframe-hub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 8:21pm

@TobiTenno TobiTenno enabled auto-merge (squash) February 1, 2024 03:01
@TobiTenno TobiTenno merged commit 92550e3 into WFCD:dev Feb 1, 2024
7 checks passed
wfcd-bot-boi pushed a commit that referenced this pull request Feb 1, 2024
## [2.4.5](v2.4.4...v2.4.5) (2024-02-01)

### Bug Fixes

* various BountyPanel bugs ([#1156](#1156)) ([92550e3](92550e3))
@wfcd-bot-boi
Copy link
Collaborator

🎉 This PR is included in version 2.4.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants