Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: convert hub to nuxt project #731

Merged
merged 6 commits into from
Apr 11, 2022
Merged

feat: convert hub to nuxt project #731

merged 6 commits into from
Apr 11, 2022

Conversation

TobiTenno
Copy link
Member

@TobiTenno TobiTenno commented Mar 15, 2022 •
edited
Loading

Summary:
Convert to nuxt-based app
should make it easier to maintain and keep up with vue changes in the long run and have a bit more of a stable community

vue-mobile-detection -> @nuxt/device
sentry modules -> @nuxt/sentry
App.vue -> default layout

Fixes issue (include link):
closes #691

Mockups, screenshots, evidence:

@TobiTenno TobiTenno requested a review from a team as a code owner March 15, 2022 02:24
@TobiTenno TobiTenno requested a review from Bitti09 March 15, 2022 02:24
@vercel
Copy link

vercel bot commented Mar 15, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/wfcd/warframe-hub/BzV5hjSCJRc2hrtR5WrCGWvJrLCx
✅ Preview: https://warframe-hub-git-nuxt-wfcd.vercel.app

@TobiTenno TobiTenno changed the title feat: initial nuxt progress [wip] feat: initial nuxt progress Mar 15, 2022
@TobiTenno TobiTenno requested a review from EricSihaoLin March 15, 2022 03:56
@TobiTenno TobiTenno self-assigned this Mar 15, 2022
@TobiTenno TobiTenno changed the title [wip] feat: initial nuxt progress feat: initial nuxt progress Mar 15, 2022
@TobiTenno TobiTenno changed the title feat: initial nuxt progress feat: convert hub to nuxt project Mar 15, 2022
TobiTenno
TobiTenno commented Mar 16, 2022
View reviewed changes
components/panels/ConstructionPanel.vue Outdated Show resolved Hide resolved
components/panels/ConstructionPanel.vue Outdated Show resolved Hide resolved
static/sw.js Outdated Show resolved Hide resolved
pages/vallis/map.vue Outdated Show resolved Hide resolved
layouts/default.vue Outdated Show resolved Hide resolved
layouts/default.vue Outdated Show resolved Hide resolved
@TobiTenno
Copy link
Member Author

@Bitti09 I'd love your thoughts on these since you have a bit more experience with nuxt than I do, and you've typically got some pretty good thoughts. I worry that i've got too much freeform vue paradigms in play with my config & stuff like static asset usage

@EricSihaoLin
Copy link
Member

I read through all the changes from a javascript standpoint, all of these I assume are just convention changes. The only thing is perhaps we should change the icon of the app.

@TobiTenno
Copy link
Member Author

agreed, i'm working with yazu on one based off of the materials logo

@TobiTenno
Copy link
Member Author

I'll rebase once I sort out the logo with yazu

@TobiTenno
Copy link
Member Author

@EricSihaoLin any additional thoughts?

@TobiTenno TobiTenno merged commit d23dc8e into dev Apr 11, 2022
@TobiTenno TobiTenno deleted the nuxt branch April 11, 2022 20:23
wfcd-bot-boi pushed a commit that referenced this pull request Apr 11, 2022
@semantic-release-bot
chore(release): 2.0.0 [skip ci]
634b6f3 
# [2.0.0](v1.6.6...v2.0.0) (2022-04-11)

### Features

* convert hub to nuxt project ([#731](#731)) ([d23dc8e](d23dc8e))

### BREAKING CHANGES

* breaks the url patterns because it removes the `#` fragmet notation
@wfcd-bot-boi
Copy link
Collaborator

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricSihaoLin EricSihaoLin EricSihaoLin approved these changes

@Bitti09 Bitti09 Awaiting requested review from Bitti09 Bitti09 is a code owner automatically assigned from WFCD/warframe-hub

Assignees

@TobiTenno TobiTenno

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🤔 Migrate to nuxt.js
3 participants
@TobiTenno @EricSihaoLin @wfcd-bot-boi