Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spec] Navigating from the default FencedFrameConfig(url) constructor doesn't install a fenced frame config. #178

Closed
blu25 opened this issue Aug 16, 2024 · 1 comment
Labels
specification Additions to specifications

Comments

@blu25
Copy link
Collaborator

blu25 commented Aug 16, 2024

The default FencedFrameConfig(url) constructor does not install a fenced frame config in the spec. FencedFrameConfig(url) puts a url into the url slot, and then we can pass in either a url or urn to the navigate algorithm. The navigate algorithm only creates a fenced frame config struct and sets the target fenced frame config if the value passed in is a urn. So, if we pass in a url to that algorithm instead, no fenced frame config will be created, and no fenced frame config instance will be created either, so the fenced frame won't have access to window.fence.

This should create a fenced frame config + install a fenced frame config instance unconditionally, but that is not what is happening currently.

@shivanigithub shivanigithub added the specification Additions to specifications label Aug 16, 2024
@blu25 blu25 changed the title Navigating from the default FencedFrameConfig(url) constructor doesn't install a fenced frame config. [Spec] Navigating from the default FencedFrameConfig(url) constructor doesn't install a fenced frame config. Aug 16, 2024
@blu25
Copy link
Collaborator Author

blu25 commented Aug 16, 2024

Note that when this is implemented, the effective sandbox flags will need to be set to the default constructor value (see kFencedFrameForcedSandboxFlags for the list of flags it will need to be set to).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
specification Additions to specifications
Projects
None yet
Development

No branches or pull requests

2 participants