white list

[WW3]

should [contenteditable], video[controls], audio[controls] also be white listed?

[robdodson]

I believe items in whitelist are ones that should always display a focus ring.

[contenteditable] seems to, when I try it in Chrome, Firefox, and Safari.

audio and video controls don't seem to in Chrome or Safari but they do in Firefox.

My hunch is we wouldn't want to add those two because they work very similar to <button>. @alice wdyt?

[bradkemper]

I think the general idea behind showing focus rings on text fields is that you can see where your typing is going to go if you start typing some words. You can then expect to see your words show up within that rectangle. So I would say [contenteditable] should be on the white list, but video controls should not be.

[jonathantneal]

Depending on the result of #34, I can file a pull request to whitelist contenteditable.

UPDATE: Nevermind, @kloots is on it with #37.

Test Page

I tested this page in Edge and Internet Explorer 11. None of these elements receive an outline from a pointer, but they all do from a keyboard. In Chrome 48, Firefox 53, and Safari 10.1.1, [contenteditable] receives an outline from a pointer, but the media elements do not.

As an aside, I follow @bradkemper’s rationale, and I think this non-outline behavior in IE/Edge is unexpected.

[kloots]

@WW3 I've cut a PR to address this issue as the current behavior needs to be tuned IMO. Currently it requires an ARIA role of textbox to match and would also match if an element only had a role of textbox and no contenteditable attribute—which isn't right. I think the right approach is to simply key off of the contenteditable attribute.

[robdodson]

Looks like this is fixed by #37 so I'm going to close this issue.