Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ambiguous language in section 2.2, "has not shifted in $X or $Y" #67

Open
dholbert opened this issue Aug 10, 2020 · 4 comments
Open
Assignees

Comments

@dholbert
Copy link
Contributor

dholbert commented Aug 10, 2020

Ambiguous language in section 2.2 here:
https://wicg.github.io/layout-instability/#sec-basic-concepts

there does not exist an Element P such that
[...conditions...] and:
4. N has not shifted in the coordinate space of the local coordinate system or scrollable overflow region of P.

This language is currently ambiguous -- it's not clear what the "or" means here.

This could be read to mean two very different things:
Interpretation A:
"Either: N has not shifted in the coordinate space of the local coordinate system of P, or N has not shifted in the scrollable overflow region of P"

Interpretation B:
"N has not shifted in the coordinate space of the local coordinate system of P, nor has it shifted in the scrollable overflow region of P."

Please reword to make it unambiguous.

@dholbert
Copy link
Contributor Author

Note that this section is particularly tricky to reason about given all of the layers of negation ("N is unstable if: [...] there does not exist an element P such that: [...] N has not shifted in ...")

(Hence the importance of making the language as explicit & unambiguous as possible.)

@dholbert
Copy link
Contributor Author

Put another way: its not clear to me which of these is what the spec is trying to say:

Interpretation A:
"N counts as 'stable' if it stayed fixed in either the local coordinate system of of P or in the scrollable overflow region of P"

...vs:
Interpretation B:
"N counts as 'stable' if it stayed fixed in both the local coordinate system of P and in the scrollable overflow region of P"

@dholbert dholbert changed the title Fix ambiguous language on "has not shifted in $X or $Y" language Fix ambiguous language in section 2.2, "has not shifted in $X or $Y" Aug 10, 2020
@npm1
Copy link
Collaborator

npm1 commented Aug 11, 2020

Assigning to Steve, should be a one-line fix.

@clelland
Copy link

clelland commented Nov 9, 2022

Closing, this was addressed in 421c82b. Looks like @skobes removed the "local coordinate system" in that commit, and also removed any "OR" clauses from inside that section of the algorithm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants