Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What design should be used for reporting navigation duration? #33

Closed
domenic opened this issue Feb 11, 2021 · 1 comment · Fixed by #125
Closed

What design should be used for reporting navigation duration? #33

domenic opened this issue Feb 11, 2021 · 1 comment · Fixed by #125
Labels
surface api Minor tweaks or additions to the API surface to make it nicer (without changing the model)

Comments

@domenic
Copy link
Collaborator

domenic commented Feb 11, 2021

After #27, the proposal discusses how you can get the "duration of the navigation" via event.timeStamp - event.startTime, at least for same-document navigations. It has an open question about whether this should work for cross-document navigations (related to #31).

A larger question is whether this property-on-an-event design is the right approach at all. We need to coordinate with the WebPerf folks, e.g. @yoavweiss is apparently working on a way to generate PerformanceEntry instances for bfcache navigations, which have some similarities to same-document navigations. Maybe (probably?) we should just have same-document navigations be measured via the those performance timeline mechanisms as well.
domenic added a commit that referenced this issue Feb 11, 2021
@domenic
Rename and update semantics for navigation duration measurement
5cefb71 
Closes #8 by renaming to something shorter, although not to the proposed name since navigationStart is apparently deprecated.

Closes #12 by changing the semantics to when the navigation is initiated to be more useful.

Points to #33 for further work on this area.
@domenic domenic added the surface api Minor tweaks or additions to the API surface to make it nicer (without changing the model) label Feb 17, 2021
This was referenced Mar 5, 2021
Closed
Closed
@domenic domenic mentioned this issue Apr 2, 2021
Merged
@kenchris
Copy link

The @w3ctag think that is makes sense to use the same primitive for this and bfcache navigations, but developers should be able to see what navigation type happened so that you can differentiate the two

domenic added a commit that referenced this issue May 27, 2021
@domenic
Introduce performance timeline API integration
1ba7eb8 
This replaces our previous broken idea of using currentchange for this. Closes #59. Closes #33. #14 remains to track whether currentchange is actually useful.
@domenic domenic mentioned this issue May 27, 2021
Merged
domenic added a commit that referenced this issue Jun 4, 2021
@domenic
Introduce performance timeline API integration
5a76650 
This replaces our previous broken idea of using currentchange for duration tracking. Closes #59. Closes #33. Closes #14 by removing currentchange entirely for now (we can always add it back later if we see a use case).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
surface api Minor tweaks or additions to the API surface to make it nicer (without changing the model)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce performance timeline API integration WICG/navigation-api
2 participants
@domenic @kenchris