-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppHistoryEntry.sameDocument #70
Comments
I think it would change a bit earlier, the moment respondWith() is called. But yeah, that's the idea. |
so I went and reread the actual spec text, and found this line:
if I'm understanding that correctly, that actually just says that when you push the browser back button, you can ignore the text below now, probably. I'll keep it here for reference, but I think my edit above is much more clear.a related question, regarding same-document vs cross-document navigations: in your example here https://gigantic-honored-octagon.glitch.me it says
Normally clicking the back button to go back to But because appHistory intercepted the navigation from So when the browser UI's back button is clicked, appHistory must first check the entries list and see if that url exists (and double check And in your example, it would find that URL and see that Does all of that sound right? If it is, the type of navigation would be caused by a Sorry, that's a long one. I just wanted to be sure I understood as I worked on back-button event handling. 😊 |
You can have two different URLs with the same document. That happens any time there's a single-page navigation, e.g.:
See also https://github.com/WICG/app-history#appendix-types-of-navigations which tries to go into this in some more detail. |
Let's fold this into #97. The current direction we're thinking there is that |
Forgive me if this is an easy/obvious question:
Currently
sameDocument
is defined as:It's also said that
In the docs about same-document navigations, it says
With that in mind, should
sameDocument
always change totrue
(if it wasn't already) in the complete event sequence stepsix
andx
where the promise is resolved?Thanks in advance for your patience. 🙂
The text was updated successfully, but these errors were encountered: