Spec for focusReset and scrollRestoration #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
force-pushed
the
focus-scrollrestoration-spec
branch
from
e3d8a35
to
da140c0
Compare
domenic
commented
Feb 7, 2022
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 8, 2022
Based on the draft at WICG/navigation-api#201. This includes handling multiple conflicting focusReset options, with a console warning if necessary. Limitations, to be addressed in future commits: * This does not take into account autofocus="" elements. * This will reset focus even if the user has moved focus in the meantime. Bug: 1183545 Change-Id: I1eae4fc58af653fa7e463a1346a9bebc9536a59f
domenic
commented
Feb 8, 2022
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 14, 2022
Based on the draft at WICG/navigation-api#201. This includes handling multiple conflicting focusReset options, with a console warning if necessary. Limitations, to be addressed in future commits: * This does not take into account autofocus="" elements. * This will reset focus even if the user has moved focus in the meantime. Bug: 1183545 Change-Id: I1eae4fc58af653fa7e463a1346a9bebc9536a59f
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 14, 2022
Based on the draft at WICG/navigation-api#201. This includes handling multiple conflicting focusReset options, with a console warning if necessary. Limitations, to be addressed in future commits: * This does not take into account autofocus="" elements. * This will reset focus even if the user has moved focus in the meantime. Bug: 1183545 Change-Id: I1eae4fc58af653fa7e463a1346a9bebc9536a59f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441109 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#970838}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 14, 2022
Based on the draft at WICG/navigation-api#201. This includes handling multiple conflicting focusReset options, with a console warning if necessary. Limitations, to be addressed in future commits: * This does not take into account autofocus="" elements. * This will reset focus even if the user has moved focus in the meantime. Bug: 1183545 Change-Id: I1eae4fc58af653fa7e463a1346a9bebc9536a59f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441109 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#970838}
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Feb 14, 2022
Based on the draft at WICG/navigation-api#201. This includes handling multiple conflicting focusReset options, with a console warning if necessary. Limitations, to be addressed in future commits: * This does not take into account autofocus="" elements. * This will reset focus even if the user has moved focus in the meantime. Bug: 1183545 Change-Id: I1eae4fc58af653fa7e463a1346a9bebc9536a59f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441109 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#970838}
mattwoodrow
pushed a commit
to mattwoodrow/wpt
that referenced
this pull request
Feb 15, 2022
Based on the draft at WICG/navigation-api#201. This includes handling multiple conflicting focusReset options, with a console warning if necessary. Limitations, to be addressed in future commits: * This does not take into account autofocus="" elements. * This will reset focus even if the user has moved focus in the meantime. Bug: 1183545 Change-Id: I1eae4fc58af653fa7e463a1346a9bebc9536a59f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441109 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#970838}
DanielRyanSmith
pushed a commit
to DanielRyanSmith/wpt
that referenced
this pull request
Feb 28, 2022
Based on the draft at WICG/navigation-api#201. This includes handling multiple conflicting focusReset options, with a console warning if necessary. Limitations, to be addressed in future commits: * This does not take into account autofocus="" elements. * This will reset focus even if the user has moved focus in the meantime. Bug: 1183545 Change-Id: I1eae4fc58af653fa7e463a1346a9bebc9536a59f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441109 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#970838}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 8, 2022
…=testonly Automatic update from web-platform-tests App history: basic focusReset support Based on the draft at WICG/navigation-api#201. This includes handling multiple conflicting focusReset options, with a console warning if necessary. Limitations, to be addressed in future commits: * This does not take into account autofocus="" elements. * This will reset focus even if the user has moved focus in the meantime. Bug: 1183545 Change-Id: I1eae4fc58af653fa7e463a1346a9bebc9536a59f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441109 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#970838} -- wpt-commits: e6bbf057e52677c2f90fc22925673e3ca72bcd69 wpt-pr: 32750
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Mar 8, 2022
…=testonly Automatic update from web-platform-tests App history: basic focusReset support Based on the draft at WICG/navigation-api#201. This includes handling multiple conflicting focusReset options, with a console warning if necessary. Limitations, to be addressed in future commits: * This does not take into account autofocus="" elements. * This will reset focus even if the user has moved focus in the meantime. Bug: 1183545 Change-Id: I1eae4fc58af653fa7e463a1346a9bebc9536a59f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441109 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#970838} -- wpt-commits: e6bbf057e52677c2f90fc22925673e3ca72bcd69 wpt-pr: 32750
dvoytenko
reviewed
Mar 23, 2022
| }; | ||
|
|
||
| enum AppHistoryFocusReset { | ||
| "after-transition", |
There was a problem hiding this comment.
To clarify, with this value, what would happen if the user-land code would display:none a previously focused element? Would the document.activeElement and focus, focusin, etc events all be delayed until after the transition is complete?
There was a problem hiding this comment.
No, that would immediately reset the focus (since the focus changed). Then, after the transition completes, if focus hasn't been moved manually, focus would get reset again to the first autofocus="" element or to the body.
spec.bs
Outdated
|
|
||
| <p>The given |newNavigationAction| promise is used to signal the duration, and success or failure, of the navigation. After it settles, the browser signals to the user (e.g. via a loading spinner UI, or assistive technology) that the navigation is finished. Additionally, it fires {{AppHistory/navigatesuccess}} or {{AppHistory/navigateerror}} events as appropriate, which other parts of the web application can respond to. | ||
|
|
||
| <p>By default, using this method will cause focus to reset when the |newNavigationAction| promise (and any other promises passed in other calls to {{AppHistoryNavigateEvent/transitionWhile()}}) settle. Focus will be reset to the first element with the <{html-global/autofocus}> attribute set, or the <{body}> element if the attribute isn't present. The {{AppHistoryTransitionWhileOptions/focusReset}} option can be set to "{{AppHistoryFocusReset/manual}}" to avoid this behavior. |
There was a problem hiding this comment.
Elsewhere we discussed that maybe if the currently focused element didn't end up display:none or content-visibility:hidden or removed from DOM entirely - perhaps it should stay focused? Or would we leave it to the "manual" mode?
There was a problem hiding this comment.
That is the exact meaning of the "manual" mode :).
domenic
force-pushed
the
focus-scrollrestoration-spec
branch
from
da140c0
to
3935bb1
Compare
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 29, 2022
SFNSP = sequential focus navigation starting point. This was noticed while writing the spec at WICG/navigation-api#201. Bug: 1183545 Change-Id: If13f3c12e9c6ef2dbed628a65b823754ae04cd3d
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Mar 29, 2022
SFNSP = sequential focus navigation starting point. This was noticed while writing the spec at WICG/navigation-api#201. Bug: 1183545 Change-Id: If13f3c12e9c6ef2dbed628a65b823754ae04cd3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550462 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#986705}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 29, 2022
SFNSP = sequential focus navigation starting point. This was noticed while writing the spec at WICG/navigation-api#201. Bug: 1183545 Change-Id: If13f3c12e9c6ef2dbed628a65b823754ae04cd3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550462 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#986705}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 29, 2022
SFNSP = sequential focus navigation starting point. This was noticed while writing the spec at WICG/navigation-api#201. Bug: 1183545 Change-Id: If13f3c12e9c6ef2dbed628a65b823754ae04cd3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550462 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#986705}
domenic
force-pushed
the
focus-scrollrestoration-spec
branch
from
9229a15
to
e2843c9
Compare
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 2, 2022
…SFNSP, a=testonly Automatic update from web-platform-tests Navigation API: focusReset should reset SFNSP SFNSP = sequential focus navigation starting point. This was noticed while writing the spec at WICG/navigation-api#201. Bug: 1183545 Change-Id: If13f3c12e9c6ef2dbed628a65b823754ae04cd3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550462 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#986705} -- wpt-commits: 9ab820e5ba017bac6d8729281c983618b79b7637 wpt-pr: 33408
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Apr 5, 2022
…SFNSP, a=testonly Automatic update from web-platform-tests Navigation API: focusReset should reset SFNSP SFNSP = sequential focus navigation starting point. This was noticed while writing the spec at WICG/navigation-api#201. Bug: 1183545 Change-Id: If13f3c12e9c6ef2dbed628a65b823754ae04cd3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550462 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#986705} -- wpt-commits: 9ab820e5ba017bac6d8729281c983618b79b7637 wpt-pr: 33408
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
Based on the draft at WICG/navigation-api#201. This includes handling multiple conflicting focusReset options, with a console warning if necessary. Limitations, to be addressed in future commits: * This does not take into account autofocus="" elements. * This will reset focus even if the user has moved focus in the meantime. Bug: 1183545 Change-Id: I1eae4fc58af653fa7e463a1346a9bebc9536a59f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3441109 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#970838} NOKEYCHECK=True GitOrigin-RevId: d9ba2f92e64c9c06554722bf4c767b3004bbbe3c
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
SFNSP = sequential focus navigation starting point. This was noticed while writing the spec at WICG/navigation-api#201. Bug: 1183545 Change-Id: If13f3c12e9c6ef2dbed628a65b823754ae04cd3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550462 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#986705} NOKEYCHECK=True GitOrigin-RevId: 2bd9bbfa97719851dd07498308d8b06c3321d7f4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff