Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

form select "onchange" causing form.submit does not trigger a soft-nav... #15

Open
dlueth opened this issue May 4, 2023 · 3 comments
Open

Comments

@dlueth
Copy link

dlueth commented May 4, 2023

... but it feels like it should, correct?

@yoavweiss
Copy link
Collaborator

Do you have an example test case that'd enable me to get a better understanding of this?

@tunetheweb
Copy link
Contributor

I think I was talking to @dlueth about this when he raised it, but can't find out where.

I think it was basically the case shown by this simple demo:
https://www.tunetheweb.com/experiments/softnavsdemo/onchange.html

@tunetheweb
Copy link
Contributor

Actually the "causing form.submit" confuses me. Using form.submit() from JavaScript will cause a hard navigation (you should use form.requestSubmit() if want to be able to use preventDefault() to prevent the navigation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants