Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some soft navigations don't modify the DOM and hence not detected #8

Open
yoavweiss opened this issue Nov 24, 2022 · 2 comments
Open

Comments

@yoavweiss
Copy link
Collaborator

crbug/1372020 provides an example for a site where soft navigations modify the URL, and then animate to a previously hidden part of the page. As such, they are not triggering DOM modifications on their own, but from a user experience, that doesn't matter much. Ideally we can avoid these false negatives.

@yoavweiss
Copy link
Collaborator Author

The example in question seems to be switching between "tabs" be applying visibility hidden and transform -100% to the tabs content element.

One potential approach could be to expand the heuristic to try and capture visibility changes and/or CSS transforms that impact a large %age of the viewport.

At the same time, I wonder if there's expected work on markup patterns to enable tabs in a more semantic way (that'd be easier to detect)

^^ @mfreed7

@mfreed7
Copy link

mfreed7 commented Sep 5, 2023

At the same time, I wonder if there's expected work on markup patterns to enable tabs in a more semantic way (that'd be easier to detect)

OpenUI (and perhaps soon @dbaron) is interested in working on tabs, perhaps by adding something like <tabs>. But this almost surely isn't happening in 2023. So I wouldn't hang your hat on that solving this problem soon, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants