Specify the HTML spec integration #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irori
reviewed
Mar 29, 2022
hayatoito
reviewed
Mar 30, 2022
hiroshige-g
force-pushed
the
WebBundleScriptSpec
branch
2 times, most recently
from
8889975
to
dacdd73
Compare
|
Rebased & reflected comments. @domenic just FYI for scripting part. While doing some new things (e.g. adding a "removed from the document" hook to script elements etc.), I expect this PR doesn't affect the semantics/mechanisms of scripts elements, as this PR doesn't process updated |
hiroshige-g
force-pushed
the
WebBundleScriptSpec
branch
from
dacdd73
to
7639a01
Compare
hiroshige-g
force-pushed
the
WebBundleScriptSpec
branch
from
7639a01
to
a24a068
Compare
hayatoito
approved these changes
Apr 7, 2022
There was a problem hiding this comment.
Thanks for rebasing and cleaning up.
The PR captures our intention well! (eg. Reusing webbundle resources in "remove, then add" case).
For the detail of script parts, especially consistency with other kinds of <script> elements, I would defer to @domenic.
irori
reviewed
Apr 8, 2022
irori
approved these changes
Apr 11, 2022
|
I think it's fine to merge this at this point. Thanks! |
github-actions bot
added a commit
that referenced
this pull request
Apr 12, 2022
SHA: fcb50a7 Reason: push, by @hayatoito Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
web bundle fetch entrythat tracks fetching and reusing fetched bundles.sourceandcredentialsare moved frombundle rule, because they are associated with fetched bundles rather than rules.web bundletoweb bundle registration, to distinguish it more clearly fromweb bundle fetch entry.Preview | Diff