Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of this repository, possible changes #4

Open
nylen opened this issue Feb 28, 2020 · 0 comments
Open

Status of this repository, possible changes #4

nylen opened this issue Feb 28, 2020 · 0 comments

Comments

@nylen
Copy link
Member

nylen commented Feb 28, 2020

I've implemented this on https://docs.classicpress.net.

It's working well, and I've made some changes that could be incorporated upstream. However it looks like the version of this code being used on wordpress.org is different / outdated so I thought I'd check on whether this is still being maintained first, and if there is interest in one or more of these changes I can write them up into PRs:

  • Improved debugging for what happens when importing a manifest file: ClassicPress/site-docs@15a8c75, ClassicPress/site-docs@d083b83
  • Disable editing content, title, and slug in wp-admin (classic editor only): ClassicPress/site-docs@5c8810d
  • Expose the protected function Editor#get_markdown_edit_link publicly so that themes can implement their own front-end edit links. This will cause a back compat issue if the visibility is changed, but a new method could be added instead.
  • Do not require jetpack_require_lib() to exist on the site, allow including and manually loading the required Jetpack code instead: ClassicPress/site-docs@eecfdb7
  • Improved debug messages for what happens when importing content: ClassicPress/site-docs@9e25b76
  • Create a new method Importer#is_markdown_post that can be overridden to allow more fine-grained logic for whether a post should be managed by the Markdown sync system.

If this repository isn't being actively maintained, then at least this can serve as a reference implementation for others. More information about our setup is here: https://github.com/ClassicPress/site-docs/tree/master/wp-content/mu-plugins/markdown-sync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant