Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DetectVendorFiles.php #868

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Conversation

dunklerfox
Copy link
Contributor

I have no idea if this is the correct implementation for this. I have tested this code on a single deployment and it appears to be working correctly.

@leonstafford
Copy link
Contributor

Thanks, @dunklerfox!

I think it'll just need an additional check around that code to determine if Divi is active on the site.

From this search, looks like ET_Builder_Library may be the class to check for existence?

https://github.com/search?q=class_exists+ET_&type=code

@leonstafford
Copy link
Contributor

(so that this code doesn't run unnecessarily for users without Divi)

@john-shaffer
Copy link
Contributor

@leonstafford I'm thinking about adding an advanced option with a list of dirs and turning this into a for loop over that list.

@john-shaffer john-shaffer force-pushed the patch-1 branch 2 times, most recently from 6d2f753 to f93d13f Compare August 30, 2022 00:11
@john-shaffer john-shaffer merged commit bf6b702 into elementor:develop Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants