Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken tests in PHP 5.5 #1209

Closed
benlk opened this issue Apr 29, 2016 · 1 comment
Closed

Fix broken tests in PHP 5.5 #1209

benlk opened this issue Apr 29, 2016 · 1 comment

Comments

@benlk
Copy link
Collaborator

benlk commented Apr 29, 2016

The tests that are currently failing (see https://travis-ci.org/INN/Largo/builds/126662077 ) are related to the update functions, and I'm not sure what's causing the array-to-string conversion errors that are making them fail.

@benlk
Copy link
Collaborator Author

benlk commented Jun 14, 2016

From #1191 (comment):

Okay, yup, the failing test in PHP 5.3.29 and WordPress 4.4.2 here is because of how the test is written, and it's failing only on Travis, not in a 5.3.29/4.4.2 Vagrant.

  • rewrite test_largo_update_prominence_term_description_single to get a term from the available terms, use its description in the description-to-be-replaced field. We cannot safely assume that 'Test Description 9' will be available.

.

The tests failing in PHP 5.5, which WPEngine uses, are related to the update functions, and do need fixes.

  • array to string conversion
  • called a thing statically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants