Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "Single Post Widget" #73

Merged
merged 5 commits into from
Mar 26, 2020
Merged

Add a "Single Post Widget" #73

merged 5 commits into from
Mar 26, 2020

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Mar 25, 2020

Changes

This pull request makes the following changes:

Widget admin:

Screen Shot 2020-03-25 at 19 08 43

Comparison of styles of the Single Post widget and Largo Recent Posts:

Screen Shot 2020-03-25 at 19 10 02

Why

For #72, and to make sure that they can enable the date on posts using this code.

Testing/Questions

Features that this PR affects:

  • The pre_get_posts fix affects the categories around-the-state and mississippi-roundup. These two categories, and no others, should not display the featured posts section at the top of the category archive
  • All Largo Recent Posts widgets, and anything else that uses partials/widget-content.php

Questions that need to be answered before merging:

  • Is this PR targeting the correct branch in this repository?
  • Do we need a better UI than inserting a raw post ID?
  • Does there need to be better descriptive language regarding the post ID?
  • Do we need to remove the btn btn-primary classes from the optional "more" link?
  • Which widget areas does this need to be tested in?

Steps to test this PR:

  1. Check out this branch.
  2. Insert a MS Today Single Post widget in a widget area somewhere.
  3. Feed it a post ID and save the widget.
  4. Verify that the widget displays.
  5. Verify that all the widget options work.
  6. Switch back to master and review the various Largo Recent Posts widgets on the site. Switch back to this branch. The presence or absence of the date in bylines should be unchanged.

@benlk benlk requested a review from joshdarby March 25, 2020 23:11
@benlk benlk self-assigned this Mar 25, 2020
@benlk
Copy link
Collaborator Author

benlk commented Mar 26, 2020

Screen Shot 2020-03-26 at 16 13 00

Miranda conveyed approval from the client conditional on removing the button appearance of the more link. 830bf1b removes those.

@benlk benlk merged commit 779662c into master Mar 26, 2020
@benlk benlk deleted the 72-single-post-widget branch July 15, 2020 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

partials/widget-content.php will never display the byline date
1 participant