Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dates on article pages #405

Closed
aschweigert opened this issue Feb 16, 2015 · 3 comments
Closed

dates on article pages #405

aschweigert opened this issue Feb 16, 2015 · 3 comments
Assignees
Labels
priority: normal Must be completed before release of this version of plugin. type: bug
Milestone

Comments

@aschweigert
Copy link

On the new (single column) article pages there's no date displayed, there should be.

In the Wisconsin Watch child theme they're displayed at the very top right, see: http://wisconsinwatch.org/2015/02/ashley-furniture-fined-for-workplace-safety-violations-gets-state-tax-credits/

Let's make sure this makes it back into Largo as the default.

@aschweigert aschweigert added type: bug priority: normal Must be completed before release of this version of plugin. labels Feb 16, 2015
@aschweigert aschweigert added this to the 0.4.1 milestone Feb 16, 2015
@benlk
Copy link
Collaborator

benlk commented Feb 16, 2015

Wisconsin Watch does this by hooking largo_before_post_header: source.

Should the fix for this replicate that as a pluggable function for backwards compatibility with Wisconsin Watch, or should the date code be added to partials/content-single.php in the same spot and the Wisconsin Watch theme updated to no longer use that function?

@aschweigert
Copy link
Author

i think probably add it directly to content-single and then remove it from the wisconsin child theme, it needs to be on the article pages somewhere and that placement seems fine to me as a default

@benlk
Copy link
Collaborator

benlk commented Feb 17, 2015

Resolved with f0a944e and styling in 9fbe6e3.

@benlk benlk closed this as completed Feb 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: normal Must be completed before release of this version of plugin. type: bug
Projects
None yet
Development

No branches or pull requests

2 participants