Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some thoughts #9176

Open
TLCReuver opened this issue Jul 2, 2024 · 11 comments
Open

Some thoughts #9176

TLCReuver opened this issue Jul 2, 2024 · 11 comments

Comments

@TLCReuver
Copy link

Hi Dan,

Some thoughts of features:

1). Swiping on BigVideo like Shorts.
2). Disable Animated Gif on mobile devices because they are never shown if i am right.
This speedup loadtime on these devices (toggle in CustomizeAdvanced_Plugin)

@DanielnetoDotCom
Copy link
Member

Hi,

Thank you for your thoughts on the features. Here are my responses:

  1. Swiping on BigVideo like Shorts:

    • I may consider adding this feature in the future.
  2. Disable Animated Gif on mobile devices:

    • Animated GIFs are currently lazy loaded, meaning they only load when the hover effect activates them. As a result, the GIFs should not load if they are never shown.

@TLCReuver
Copy link
Author

TLCReuver commented Jul 3, 2024

Hi Dan,

I captured two screenrecordings on a mobile device and the browser_cache is cleared before recording.
There is a huge difference in pageload and also with infinite scroll when enabling or disabling Animated GIFs.
I tried this also on a android_tablet with the same result. On desktop i see no difference,

Screencapture with Animated GIFs ENabled

(You see building up the first page)

_Zonder.titel_01.mp4

Screencapture with Animated GIFs DISabled

(The first page is ready immediately)

_Zonder.titel.mp4

@DanielnetoDotCom
Copy link
Member

where do you enable/disable Animated GIFs ?

@TLCReuver
Copy link
Author

In [CustomizeAdvanced) Version: @1.0

_Snap14

DanielnetoDotCom pushed a commit that referenced this issue Jul 3, 2024
@DanielnetoDotCom
Copy link
Member

I am still not 100% if that is the animated gif.

I could add something to not add the gif on mobile, but the main problem is that the cache use the same for mobile and desktop.

if the mobile starts to be different I would need to separate mobile and desktop cache, it will double the cache size

@TLCReuver
Copy link
Author

I understand.

Split it out in the script ... but that might slow down the cache.

Maybe oversimplified by me

@DanielnetoDotCom
Copy link
Member

I made some iprovements in the lazyload , can you please check this update?

check if still loading the gifs,

@TLCReuver
Copy link
Author

It speeding up something but disabling GIF's is much faster.

GIF's are not displayed on mobile, only the *thumbsV2.JPGs

@DanielnetoDotCom
Copy link
Member

I did inspect the mobile and I did not see any animated image loading.
any idea what is still loading?
did you clear the cache after the update?

@TLCReuver
Copy link
Author

TLCReuver commented Jul 3, 2024

Yes, i cleared cache after update and no gifs are shown.
It seem that the gifs are not the problem.... something on mobile_view is holding up but i don't see time problems in Avideo.log.
I disabled everything what could be holding up like Live, Shorts etc. but see no difference (clearing cache during disabling)
Very strange but i noticed this issue a long time ago. When animted gifs is disabled it goes like a rocket.
You can check it on https://archief.beesel-reuver.nl and you see that desktopversion is faster.

@DanielnetoDotCom
Copy link
Member

Currently I have no clue what it could be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants