Merge pull request #1300 from WalletConnect/sample-bugs-fixes

fix crash on sendTransaction request
WalletConnect · Feb 8, 2024 · 853bca5 · 853bca5
2 parents 44061fb + dbc05ca
commit 853bca5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/Example/Shared/Signer/ETHSigner.swift b/Example/Shared/Signer/ETHSigner.swift
@@ -32,12 +32,14 @@ struct ETHSigner {
         return AnyCodable(result)
     }
 
-    func sendTransaction(_ params: AnyCodable) -> AnyCodable {
-        let params = try! params.get([EthereumTransaction].self)
+    func sendTransaction(_ params: AnyCodable) throws -> AnyCodable {
+        let params = try params.get([EthereumTransaction].self)
         var transaction = params[0]
         transaction.gas = EthereumQuantity(quantity: BigUInt("1234"))
+        transaction.nonce = EthereumQuantity(quantity: BigUInt("0"))
+        transaction.gasPrice = EthereumQuantity(quantity: BigUInt(0))
         print(transaction.description)
-        let signedTx = try! transaction.sign(with: self.privateKey, chainId: 4)
+        let signedTx = try transaction.sign(with: self.privateKey, chainId: 4)
         let (r, s, v) = (signedTx.r, signedTx.s, signedTx.v)
         let result = r.hex() + s.hex().dropFirst(2) + String(v.quantity, radix: 16)
         return AnyCodable(result)

diff --git a/Example/Shared/Signer/Signer.swift b/Example/Shared/Signer/Signer.swift
@@ -20,7 +20,7 @@ final class Signer {
             return signer.signTypedData(request.params)
 
         case "eth_sendTransaction":
-            return signer.sendTransaction(request.params)
+            return try signer.sendTransaction(request.params)
 
         case "solana_signTransaction":
             return SOLSigner.signTransaction(request.params)