Merge pull request #1247 from WalletConnect/add-mixpanel-to-w3w

Mixpanel in w3w fix
WalletConnect · Dec 1, 2023 · 889d44d · 889d44d
2 parents aee8c77 + 0783f0f
commit 889d44d
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 2 deletions.
diff --git a/Sources/WalletConnectPairing/PairingClientFactory.swift b/Sources/WalletConnectPairing/PairingClientFactory.swift
@@ -26,7 +26,7 @@ public struct PairingClientFactory {
         let kms = KeyManagementService(keychain: keychainStorage)
         let history = RPCHistoryFactory.createForNetwork(keyValueStorage: keyValueStorage)
         let appPairService = AppPairService(networkingInteractor: networkingClient, kms: kms, pairingStorage: pairingStore)
-        let walletPairService = WalletPairService(networkingInteractor: networkingClient, kms: kms, pairingStorage: pairingStore, history: history)
+        let walletPairService = WalletPairService(networkingInteractor: networkingClient, kms: kms, pairingStorage: pairingStore, history: history, logger: logger)
         let pairingRequestsSubscriber = PairingRequestsSubscriber(networkingInteractor: networkingClient, pairingStorage: pairingStore, logger: logger)
         let pairingsProvider = PairingsProvider(pairingStorage: pairingStore)
         let cleanupService = PairingCleanupService(pairingStore: pairingStore, kms: kms)

diff --git a/Tests/WalletConnectPairingTests/WalletPairServiceTests.swift b/Tests/WalletConnectPairingTests/WalletPairServiceTests.swift
@@ -18,7 +18,7 @@ final class WalletPairServiceTestsTests: XCTestCase {
         storageMock = WCPairingStorageMock()
         cryptoMock = KeyManagementServiceMock()
         rpcHistory = RPCHistoryFactory.createForNetwork(keyValueStorage: RuntimeKeyValueStorage())
-        service = WalletPairService(networkingInteractor: networkingInteractor, kms: cryptoMock, pairingStorage: storageMock, history: rpcHistory)
+        service = WalletPairService(networkingInteractor: networkingInteractor, kms: cryptoMock, pairingStorage: storageMock, history: rpcHistory, logger: ConsoleLoggerMock())
     }
 
     func testPairWhenNetworkNotConnectedThrows() async {

diff --git a/Tests/Web3WalletTests/Mocks/PairingClientMock.swift b/Tests/Web3WalletTests/Mocks/PairingClientMock.swift
@@ -4,6 +4,12 @@ import Combine
 @testable import WalletConnectPairing
 
 final class PairingClientMock: PairingClientProtocol {
+    private var logsSubject = PassthroughSubject<WalletConnectUtils.Log, Never>()
+
+    var logsPublisher: AnyPublisher<WalletConnectUtils.Log, Never> {
+        return logsSubject.eraseToAnyPublisher()
+    }
+
     var pairCalled = false
     var disconnectPairingCalled = false
 

diff --git a/Tests/Web3WalletTests/Mocks/SignClientMock.swift b/Tests/Web3WalletTests/Mocks/SignClientMock.swift
@@ -4,6 +4,11 @@ import Combine
 @testable import WalletConnectSign
 
 final class SignClientMock: SignClientProtocol {
+    private var logsSubject = PassthroughSubject<WalletConnectUtils.Log, Never>()
+
+    var logsPublisher: AnyPublisher<WalletConnectUtils.Log, Never> {
+        return logsSubject.eraseToAnyPublisher()
+    }
     var approveCalled = false
     var rejectCalled = false
     var updateCalled = false