Skip to content

Commit

Permalink
Unit tests build error
Browse files Browse the repository at this point in the history
  • Loading branch information
flypaper0 committed Oct 25, 2022
1 parent 53f10b5 commit a3b4639
Show file tree
Hide file tree
Showing 7 changed files with 19 additions and 12 deletions.
2 changes: 1 addition & 1 deletion Example/IntegrationTests/Auth/AuthTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ final class AuthTests: XCTestCase {
func makeClients(prefix: String, account: Account? = nil, iatProvider: IATProvider) -> (PairingClient, AuthClient) {
let logger = ConsoleLogger(suffix: prefix, loggingLevel: .debug)
let keychain = KeychainStorageMock()
let relayClient = RelayClient(relayHost: InputConfig.relayHost, projectId: InputConfig.projectId, keychainStorage: keychain, socketFactory: SocketFactory(), logger: logger)
let relayClient = RelayClient(relayHost: InputConfig.relayHost, projectId: InputConfig.projectId, keychainStorage: keychain, socketFactory: SocketFactory(), logger: logger, timeout: Int(InputConfig.defaultTimeout))
let keyValueStorage = RuntimeKeyValueStorage()

let networkingClient = NetworkingClientFactory.create(
Expand Down
2 changes: 1 addition & 1 deletion Example/IntegrationTests/Chat/ChatTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ final class ChatTests: XCTestCase {
func makeClient(prefix: String) -> ChatClient {
let logger = ConsoleLogger(suffix: prefix, loggingLevel: .debug)
let keychain = KeychainStorageMock()
let relayClient = RelayClient(relayHost: InputConfig.relayHost, projectId: InputConfig.projectId, keychainStorage: keychain, socketFactory: SocketFactory(), logger: logger)
let relayClient = RelayClient(relayHost: InputConfig.relayHost, projectId: InputConfig.projectId, keychainStorage: keychain, socketFactory: SocketFactory(), logger: logger, timeout: Int(InputConfig.defaultTimeout))
return ChatClientFactory.create(registry: registry, relayClient: relayClient, kms: KeyManagementService(keychain: keychain), logger: logger, keyValueStorage: RuntimeKeyValueStorage())
}

Expand Down
3 changes: 2 additions & 1 deletion Example/IntegrationTests/Pairing/PairingTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ final class PairingTests: XCTestCase {
keyValueStorage: RuntimeKeyValueStorage(),
keychainStorage: keychain,
socketFactory: SocketFactory(),
logger: relayLogger)
logger: relayLogger,
timeout: Int(InputConfig.defaultTimeout))

let networkingClient = NetworkingClientFactory.create(
relayClient: relayClient,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ final class RelayClientEndToEndTests: XCTestCase {
let socket = WebSocket(url: urlFactory.create(host: InputConfig.relayHost, projectId: InputConfig.projectId))

let logger = ConsoleLogger()
let dispatcher = Dispatcher(socket: socket, socketConnectionHandler: ManualSocketConnectionHandler(socket: socket), logger: logger)
let dispatcher = Dispatcher(socket: socket, socketConnectionHandler: ManualSocketConnectionHandler(socket: socket), logger: logger, timeout: Int(InputConfig.defaultTimeout))
return RelayClient(dispatcher: dispatcher, logger: logger, keyValueStorage: RuntimeKeyValueStorage(), clientIdStorage: clientIdStorage)
}

Expand Down
3 changes: 2 additions & 1 deletion Example/IntegrationTests/Sign/SignClientTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ final class SignClientTests: XCTestCase {
keychainStorage: keychain,
socketFactory: SocketFactory(),
socketConnectionType: .automatic,
logger: logger
logger: logger,
timeout: Int(InputConfig.defaultTimeout)
)
let keyValueStorage = RuntimeKeyValueStorage()

Expand Down
14 changes: 9 additions & 5 deletions Sources/WalletConnectRelay/Dispatching.swift
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ final class Dispatcher: NSObject, Dispatching {
var socketConnectionHandler: SocketConnectionHandler

private let logger: ConsoleLogging
private let defaultTimeout: Int = 5
private let timeout: Int

private let socketConnectionStatusPublisherSubject = PassthroughSubject<SocketConnectionStatus, Never>()

Expand All @@ -28,11 +28,15 @@ final class Dispatcher: NSObject, Dispatching {

private let concurrentQueue = DispatchQueue(label: "com.walletconnect.sdk.dispatcher", attributes: .concurrent)

init(socket: WebSocketConnecting,
socketConnectionHandler: SocketConnectionHandler,
logger: ConsoleLogging) {
init(
socket: WebSocketConnecting,
socketConnectionHandler: SocketConnectionHandler,
logger: ConsoleLogging,
timeout: Int
) {
self.socket = socket
self.logger = logger
self.timeout = timeout
self.socketConnectionHandler = socketConnectionHandler
super.init()
setUpWebSocketSession()
Expand All @@ -58,7 +62,7 @@ final class Dispatcher: NSObject, Dispatching {
cancellable = socketConnectionStatusPublisher
.filter { $0 == .connected }
.setFailureType(to: NetworkError.self)
.timeout(.seconds(defaultTimeout), scheduler: concurrentQueue, customError: { .webSocketNotConnected })
.timeout(.seconds(timeout), scheduler: concurrentQueue, customError: { .webSocketNotConnected })
.sink(receiveCompletion: { result in
switch result {
case .failure(let error):
Expand Down
5 changes: 3 additions & 2 deletions Sources/WalletConnectRelay/RelayClient.swift
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ public final class RelayClient {
keychainStorage: KeychainStorageProtocol = KeychainStorage(serviceIdentifier: "com.walletconnect.sdk"),
socketFactory: WebSocketFactory,
socketConnectionType: SocketConnectionType = .automatic,
logger: ConsoleLogging = ConsoleLogger(loggingLevel: .off)
logger: ConsoleLogging = ConsoleLogger(loggingLevel: .off),
timeout: Int = 5
) {
let didKeyFactory = ED25519DIDKeyFactory()
let clientIdStorage = ClientIdStorage(keychain: keychainStorage, didKeyFactory: didKeyFactory)
Expand All @@ -106,7 +107,7 @@ public final class RelayClient {
case .manual:
socketConnectionHandler = ManualSocketConnectionHandler(socket: socket)
}
let dispatcher = Dispatcher(socket: socket, socketConnectionHandler: socketConnectionHandler, logger: logger)
let dispatcher = Dispatcher(socket: socket, socketConnectionHandler: socketConnectionHandler, logger: logger, timeout: timeout)
self.init(dispatcher: dispatcher, logger: logger, keyValueStorage: keyValueStorage, clientIdStorage: clientIdStorage)
}

Expand Down

0 comments on commit a3b4639

Please sign in to comment.