PR fixes

WalletConnect · Aug 10, 2023 · e7b5a7c · e7b5a7c
1 parent 0c794f4
commit e7b5a7c
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 13 deletions.
diff --git a/Sources/HTTPClient/HTTPNetworkClient.swift b/Sources/HTTPClient/HTTPNetworkClient.swift
@@ -2,7 +2,7 @@ import Foundation
 
 public actor HTTPNetworkClient: HTTPClient {
 
-    var host: String
+    private var host: String
 
     private let session: URLSession
 

diff --git a/Sources/WalletConnectEcho/Register/EchoRegisterService.swift b/Sources/WalletConnectEcho/Register/EchoRegisterService.swift
@@ -34,18 +34,14 @@ actor EchoRegisterService {
         let clientIdMutlibase = try DIDKey(did: clientId).multibase(variant: .ED25519)
         logger.debug("APNS device token: \(token)")
 
-        do {
-            let response = try await httpClient.request(
-                EchoResponse.self,
-                at: EchoAPI.register(clientId: clientIdMutlibase, token: token, projectId: projectId, environment: environment, auth: echoAuthToken)
-            )
-            guard response.status == .success else {
-                throw Errors.registrationFailed
-            }
-            logger.debug("Successfully registered at Echo Server")
-        } catch {
-            throw error
+        let response = try await httpClient.request(
+            EchoResponse.self,
+            at: EchoAPI.register(clientId: clientIdMutlibase, token: token, projectId: projectId, environment: environment, auth: echoAuthToken)
+        )
+        guard response.status == .success else {
+            throw Errors.registrationFailed
         }
+        logger.debug("Successfully registered at Echo Server")
     }
 
     func echoHostFallback() async {

diff --git a/Tests/TestingUtils/Mocks/HTTPClientMock.swift b/Tests/TestingUtils/Mocks/HTTPClientMock.swift
@@ -2,7 +2,6 @@ import Foundation
 @testable import HTTPClient
 
 public final class HTTPClientMock<T: Decodable>: HTTPClient {
-
     private let object: T
 
     public init(object: T) {
@@ -16,4 +15,8 @@ public final class HTTPClientMock<T: Decodable>: HTTPClient {
     public func request(service: HTTPService) async throws {
 
     }
+
+    public func updateHost(host: String) async {
+
+    }
 }