Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor engine methods that are still using completion handlers for responses #17

Closed
sekimondre opened this issue Jan 11, 2022 · 0 comments · Fixed by #72
Closed

Refactor engine methods that are still using completion handlers for responses #17

sekimondre opened this issue Jan 11, 2022 · 0 comments · Fixed by #72
Assignees
@sekimondre
Milestone
Beta 3

Comments

@sekimondre
Copy link

Completion handlers are volatile and can't be trusted for p2p responses received over the network. The engine behavior should be event-driven to guarantee the delivery of request-response pattern messages over web socket.
@llbartekll llbartekll added this to the Beta 3 milestone Jan 11, 2022
sekimondre pushed a commit that referenced this issue Feb 9, 2022
Merge branch '#54-account-type' into #17-engine-responses
eed465c
@sekimondre sekimondre mentioned this issue Feb 9, 2022
Merged
@sekimondre sekimondre linked a pull request Feb 9, 2022 that will close this issue
#17 engine responses #72
Merged
sekimondre pushed a commit that referenced this issue Feb 10, 2022
Merge branch 'develop' into #17-engine-responses
5e7694a
llbartekll added a commit that referenced this issue Feb 11, 2022
@llbartekll
Merge pull request #72 from WalletConnect/#17-engine-responses
13c11ac 
#17 engine responses
@chadyj chadyj mentioned this issue Aug 8, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sekimondre sekimondre

Labels
None yet
Projects
Swift SDK
Archived in project
Milestone
Beta 3
Development

Successfully merging a pull request may close this issue.

#17 engine responses WalletConnect/WalletConnectSwiftV2
2 participants
@sekimondre @llbartekll