Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tag to identify messages #297

Closed
chadyj opened this issue Jun 27, 2022 · 0 comments
Closed

Add tag to identify messages #297

chadyj opened this issue Jun 27, 2022 · 0 comments
Assignees
@sekimondre
Labels
enhancement New feature or request
Milestone
v2.0-rc.0

Comments

@chadyj
Copy link
Contributor

chadyj commented Jun 27, 2022

tag - a label that identifies which api sent a message. It allows collecting metrics. (0 - unknown, 1 - sign, 2 - chat, 3 - auth, 4 - push)

See https://github.com/WalletConnect/walletconnect-specs/blob/main/relay/relay-server.md#relay-server
@chadyj chadyj added the enhancement New feature or request label Jun 27, 2022
@chadyj chadyj added this to the v2.0-rc.1 milestone Jun 27, 2022
@chadyj chadyj mentioned this issue Jun 27, 2022
Closed
3 tasks
llbartekll pushed a commit that referenced this issue Jul 4, 2022
[Network] Feature: #297 Message Tag (#300)
f8e855b 
* Introduces tag parameter in publish calls

* Fixed unit tests build

* Fix typo

* Fixed broken tests

Co-authored-by: André Vants <andrevants@icloud.com>
@flypaper0 flypaper0 mentioned this issue Jul 5, 2022
Merged
llbartekll pushed a commit that referenced this issue Jul 5, 2022
@llbartekll
[Network] Feature: #297 Message Tag (#300)
eb1ce20 
* Introduces tag parameter in publish calls

* Fixed unit tests build

* Fix typo

* Fixed broken tests

Co-authored-by: André Vants <andrevants@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sekimondre sekimondre

Labels
enhancement New feature or request
Projects
Swift SDK
Archived in project
Milestone
v2.0-rc.0
Development

No branches or pull requests
3 participants
@chadyj @flypaper0 @sekimondre